Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 13 Oct 2019 21:54:38 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Jamie Heilman <jamie@audible.transient.net>
Cc:     linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] crypto: padlock-aes - convert to skcipher API
Message-ID: <20191014045438.GE10007@sol.localdomain>
Mail-Followup-To: Jamie Heilman <jamie@audible.transient.net>,
        linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>
References: <20191013041741.265150-1-ebiggers@kernel.org>
 <20191013232050.GA3266@audible.transient.net>
 <20191014031222.GC10007@sol.localdomain>
 <20191014044726.GB3266@audible.transient.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191014044726.GB3266@audible.transient.net>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 14, 2019 at 04:47:27AM +0000, Jamie Heilman wrote:
> Eric Biggers wrote:
> > > I built a patched 5.3.6 with none of the crypto bits modularized
> > > and you can find that dmesg and config at:
> > > 
> > > http://audible.transient.net/~jamie/k/skcipher.config-5.3.6
> > > http://audible.transient.net/~jamie/k/skcipher.dmesg
> > > 
> > 
> > Great, I don't see any test failures in the log.  Just to double
> > check, you had applied both Ard's patch and this one, right?:
> > 
> > 	crypto: geode-aes - switch to skcipher for cbc(aes) fallback
> > 	crypto: geode-aes - convert to skcipher API and make thread-safe
> 
> Er, no?  Just the VIA padlock-aes.c change from you on top of a stock
> 5.3.6 tree, nothing from Ard.  No geode here.
> 

Oops, sorry, I confused this with a different driver.  Yes, if you just applied
this padlock-aes patch it's good.

Thanks for testing!

- Eric