Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191014121910.7264-1-ard.biesheuvel@linaro.org>
 <20191014121910.7264-9-ard.biesheuvel@linaro.org> <2e544398-5407-430c-84b6-3f946f5dea0c@microchip.com>
In-Reply-To: <2e544398-5407-430c-84b6-3f946f5dea0c@microchip.com>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Tue, 15 Oct 2019 12:31:31 +0200
Message-ID: <CAKv+Gu_OueNR9ecHrqx5ROG9Pvvci69myASAW6kmj=KNuK26hQ@mail.gmail.com>
Subject: Re: [PATCH 08/25] crypto: atmel-aes - switch to skcipher API
To:     Tudor-Dan Ambarus <Tudor.Ambarus@microchip.com>
Cc:     "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Biggers <ebiggers@google.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Nicolas Ferre <Nicolas.Ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <Ludovic.Desroches@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Tue, 15 Oct 2019 at 12:17, <Tudor.Ambarus@microchip.com> wrote:
>
> Hi, Ard,
>
> Thanks for working on this.
>
> On 10/14/2019 03:18 PM, Ard Biesheuvel wrote:
> > Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interfa=
ce")
> > dated 20 august 2015 introduced the new skcipher API which is supposed =
to
> > replace both blkcipher and ablkcipher. While all consumers of the API h=
ave
> > been converted long ago, some producers of the ablkcipher remain, forci=
ng
> > us to keep the ablkcipher support routines alive, along with the matchi=
ng
> > code to expose [a]blkciphers via the skcipher API.
> >
> > So switch this driver to the skcipher API, allowing us to finally drop =
the
> > blkcipher code in the near future.
> >
> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >  drivers/crypto/atmel-aes.c | 507 ++++++++++----------
> >  1 file changed, 244 insertions(+), 263 deletions(-)
>
> drivers/crypto/atmel-aes.c: In function =E2=80=98atmel_aes_register_algs=
=E2=80=99:
> drivers/crypto/atmel-aes.c:2515:24: error: passing argument 1 of =E2=80=
=98crypto_unregister_alg=E2=80=99 from incompatible pointer type [-Werror=
=3Dincompatible-pointer-types]
>   crypto_unregister_alg(&aes_xts_alg);
>                         ^
> In file included from drivers/crypto/atmel-aes.c:32:0:
> ./include/linux/crypto.h:703:5: note: expected =E2=80=98struct crypto_alg=
 *=E2=80=99 but argument is of type =E2=80=98struct skcipher_alg *=E2=80=99
>  int crypto_unregister_alg(struct crypto_alg *alg);
>      ^~~~~~~~~~~~~~~~~~~~~
>

Apologies for that. I was pretty sure I build tested all patches, so I
should have spotted this myself.

> and when applying tdes:
> Applying: crypto: atmel-tdes - switch to skcipher API
> .git/rebase-apply/patch:637: trailing whitespace.
>
> warning: 1 line adds whitespace errors.
>
> I'll try to review the atmel part next week.
>
> Cheers,
> ta

Thanks,