Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp474698ybg; Fri, 18 Oct 2019 02:43:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqydXnqQSdbEKO/bOPVznZ0LJV5pkUo0BXbQxPL20G8tzLJls9J1CKAZTpmgELWM6EEitOrp X-Received: by 2002:aa7:c890:: with SMTP id p16mr8531811eds.296.1571391802241; Fri, 18 Oct 2019 02:43:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571391802; cv=none; d=google.com; s=arc-20160816; b=dTuaLDrhmHpFxBYbD3tvAPp2hez7fPGvnw+ErgSbScixZsCPY+OEijIgR03aV9wskd SwIvsD3huT0JXLpLEwz/kAdfXrOvmSWghG9jgbXfjfNdYeSkytVQhajQSTbB53+5H4YH dPUbxk6vbKasoGIboS53oTBUnFB/7E6Z5Q4fQSl83ckF+E+URigv2p/nfM3A005EEfZP ZT76wxQviCMJHBbaq09+DStMxqRAFtqxEkVds7PvdZr9Jjsiif4qyD/NAX4OcBcXwBxG GZEH3TRkyaXb5Cc+Ngvi1Mr0d6tAOhyJag0kU+4070wFahOKk6fyhbKbjgNIid9AqLAb 7usg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=HJS4jI9MCaVq8QatpN7qgo0WvdSAcz+NQp0vq3129Xg=; b=aagz5finp/aG2lzRHfC6ei1EIV8Xc0sooerThg8Q1nQ6f2X5QUnQA+z7o4SFjUGTMU AKr4M8MxEep2pyFd3oATwkebW+sYMFMmtWitNehmQDZm95bJrvb01W469JGdBN36MNoV YyReWGw3V2ro8JALm2Vnv8+S/01XSJKpfVWHASZFKpHcs1s7BXC13UEQxRpvyJpUI3rO H/jGROm97tNskaLMbY6gUnvnMSDOrQeIhBZ5jFM1mdhWlXU3Ctf3kLfbobV8tYzvxAYi ysTIdcot5IxHAYsw6wqvzGJGTBfqpj3f2R6WNo0ZmIIQjW2ij/IJdnvUlD7kIZSiEj1h m7wA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1si3634437edm.271.2019.10.18.02.42.58; Fri, 18 Oct 2019 02:43:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392543AbfJQGNF (ORCPT + 99 others); Thu, 17 Oct 2019 02:13:05 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:53390 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390377AbfJQGNF (ORCPT ); Thu, 17 Oct 2019 02:13:05 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8F22C6C241B7173D4BA4; Thu, 17 Oct 2019 14:13:03 +0800 (CST) Received: from [127.0.0.1] (10.63.139.185) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Thu, 17 Oct 2019 14:12:55 +0800 Subject: Re: [PATCH] crypto: zlib-deflate - add zlib-deflate test case in tcrypt To: Herbert Xu , "David S. Miller" References: <1570695707-46528-1-git-send-email-wangzhou1@hisilicon.com> CC: , From: Zhou Wang Message-ID: <5DA80666.5020504@hisilicon.com> Date: Thu, 17 Oct 2019 14:12:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1570695707-46528-1-git-send-email-wangzhou1@hisilicon.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.63.139.185] X-CFilter-Loop: Reflected Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2019/10/10 16:21, Zhou Wang wrote: > As a type CRYPTO_ALG_TYPE_ACOMPRESS is needed to trigger crypto acomp test, > we introduce a new help function tcrypto_test_extend to pass type and mask > to alg_test. > > Then tcrypto module can be used to do basic acomp test by: > insmod tcrypto.ko alg="zlib-deflate" mode=55 type=10 > > Signed-off-by: Zhou Wang > --- > crypto/tcrypt.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c > index 83ad0b1..6ad821c 100644 > --- a/crypto/tcrypt.c > +++ b/crypto/tcrypt.c > @@ -72,7 +72,7 @@ static char *check[] = { > "khazad", "wp512", "wp384", "wp256", "tnepres", "xeta", "fcrypt", > "camellia", "seed", "salsa20", "rmd128", "rmd160", "rmd256", "rmd320", > "lzo", "lzo-rle", "cts", "sha3-224", "sha3-256", "sha3-384", > - "sha3-512", "streebog256", "streebog512", > + "sha3-512", "streebog256", "streebog512", "zlib-deflate", > NULL > }; > > @@ -1657,6 +1657,19 @@ static inline int tcrypt_test(const char *alg) > return ret; > } > > +static inline int tcrypt_test_extend(const char *alg, u32 type, u32 mask) > +{ > + int ret; > + > + pr_debug("testing %s\n", alg); > + > + ret = alg_test(alg, alg, type, mask); > + /* non-fips algs return -EINVAL in fips mode */ > + if (fips_enabled && ret == -EINVAL) > + ret = 0; > + return ret; > +} > + > static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb) > { > int i; > @@ -1919,6 +1932,10 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb) > ret += tcrypt_test("streebog512"); > break; > > + case 55: > + ret += tcrypt_test_extend("zlib-deflate", type, mask); > + break; > + > case 100: > ret += tcrypt_test("hmac(md5)"); > break; > Any feedback about this patch? Best, Zhou