Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1714835ybg; Sat, 19 Oct 2019 00:56:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqwavRfqaZrwGK2hcHnxzpKn9+oSnRwxrN0W8KrwcRhE694Y+sWPU3VDkraDT01N7iYdzsX+ X-Received: by 2002:a17:906:1c87:: with SMTP id g7mr4856695ejh.189.1571471806586; Sat, 19 Oct 2019 00:56:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571471806; cv=none; d=google.com; s=arc-20160816; b=uR78pJt4oBWY2V7NJCdkbs5ZrG9VXyH+yxPGPBjq6LAaQeLCR3x9TWQV7vJ/tvaZ6d t/raYbS3hqnjqzwpyrMng3P3cWIuTZdkIY+zYBJou3ALV8dVgyBH7Z1IlPHd0mane0RT ou3OsNd1wLVfc6vIARM9rZQHfAO3zK0/FvtNcvRPDARjtU8EUQDty1acpiy4creRdwGw EM0vtjQJTgwBJJMSjqG0VQhtFASukrUwbhJu2qQwQpfOEJLFPYucwbWY5FLNVMZ79o7h Vy7TzON/Q/sQHiyWpFCQA7i4vgNSJjtkQLbnL3BxuYDlB9ubUwWVROQeTqfFF6VBsn/e jC7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=m+252l7oQuauTCzENEX6K+wXSwpBVSahSWP5LV2k4XA=; b=wk9naOxfhZjwY8ibGKnKeP94vuoxiNGP/t+EqCeAazIFvr9wmbhDzaDLOf5+YYXnjw /1emCHwXzEuvFGT7XbicAlHNPVcHEaU50eqCU+aRV9dDncT90db/oSz6Gt1cq8G2b7r/ VZFchCOWGapRC28i8/sBame7/HO5Eh6llGSbl/Zl2yyxZUZ1FGe9Lx7wjs7LX062zjX/ AmDo9b6VoqkVqMXvyTtwg5b+/QTa4i14SwGSfrIJXCUh+VhRE+PBBi+qqUrZf0t7/4ps 3SySJV0YXJPKAcf6JGHxT1BI6v2qglSPIxkT5/xrYsoRzTHpNJ3z8z35VZMm4XNRxfLK Sd5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s20si4903386eja.63.2019.10.19.00.56.22; Sat, 19 Oct 2019 00:56:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404139AbfJRIHS (ORCPT + 99 others); Fri, 18 Oct 2019 04:07:18 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:37426 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391374AbfJRIHR (ORCPT ); Fri, 18 Oct 2019 04:07:17 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1iLNHu-000226-7t; Fri, 18 Oct 2019 19:07:07 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 18 Oct 2019 19:07:06 +1100 Date: Fri, 18 Oct 2019 19:07:06 +1100 From: Herbert Xu To: Rikard Falkeborn Cc: xuzaibo@huawei.com, davem@davemloft.net, forest.zhouchang@huawei.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, tanghui20@huawei.com Subject: Re: [PATCH] crypto: hisilicon: Fix misuse of GENMASK macro Message-ID: <20191018080706.GO25128@gondor.apana.org.au> References: <1569835209-44326-2-git-send-email-xuzaibo@huawei.com> <20191015201330.25973-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191015201330.25973-1-rikard.falkeborn@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Oct 15, 2019 at 10:13:30PM +0200, Rikard Falkeborn wrote: > Arguments are supposed to be ordered high then low. > > Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator") > Signed-off-by: Rikard Falkeborn > --- > Spotted when trying to introduce compile time checking that the order > of the arguments to GENMASK are correct [0]. I have only compile tested > the patch. > > [0]: https://lore.kernel.org/lkml/20191009214502.637875-1-rikard.falkeborn@gmail.com/ > > drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt