Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To:     Tian Tao <tiantao6@huawei.com>,
        "gilad@benyossef.com" <gilad@benyossef.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     "linuxarm@huawei.com" <linuxarm@huawei.com>
Subject: RE: [PATCH] crypto: fix safexcel_hash warning PTR_ERR_OR_ZERO can be
 used
Thread-Topic: [PATCH] crypto: fix safexcel_hash warning PTR_ERR_OR_ZERO can be
 used
Thread-Index: AQHVhhbVQBWlAzI6WUy2fRE/LiLWVadkxtcw
Date:   Mon, 21 Oct 2019 08:29:31 +0000
Message-ID: <CH2PR20MB2968AC51749DDF5E457B70C5CA690@CH2PR20MB2968.namprd20.prod.outlook.com>
References: <1571445880-34025-1-git-send-email-tiantao6@huawei.com>
In-Reply-To: <1571445880-34025-1-git-send-email-tiantao6@huawei.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: verimatrix.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 89b12d04-dbf4-47c9-5401-08d75600cc6c
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2019 08:29:32.3875
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dcb260f9-022d-4495-8602-eae51035a0d0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: thgKvwFTU4pivR8wD/416e7xVjHAYrUhWU+W+Wo+wRU/qdPy1cYE32KtIDV8ZFJex+tthET4HnEqJG7WZeLzn/cRgdnV9Wmued78k2Djlxw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR20MB3013
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.=
org> On Behalf Of
> Tian Tao
> Sent: Saturday, October 19, 2019 2:45 AM
> To: gilad@benyossef.com; herbert@gondor.apana.org.au; davem@davemloft.net=
; linux-
> crypto@vger.kernel.org
> Cc: linuxarm@huawei.com
> Subject: [PATCH] crypto: fix safexcel_hash warning PTR_ERR_OR_ZERO can be=
 used
>=20
> fix below warning reported by coccicheck.
> the below code is only in the crypto-dev tree currently.
> drivers/crypto/inside-secure/safexcel_cipher.c:2527:1-3: WARNING:
> PTR_ERR_OR_ZERO can be used.
>=20
> Fixes: 38f21b4bab11 ("crypto: inside-secure - Added support for the AES X=
CBC ahash")
>=20
> Signed-off-by: Tian Tao <tiantao6@huawei.com>
> ---
>  drivers/crypto/inside-secure/safexcel_hash.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/crypto/inside-secure/safexcel_hash.c b/drivers/crypt=
o/inside-
> secure/safexcel_hash.c
> index 85c3a07..3c71151 100644
> --- a/drivers/crypto/inside-secure/safexcel_hash.c
> +++ b/drivers/crypto/inside-secure/safexcel_hash.c
> @@ -2109,10 +2109,8 @@ static int safexcel_xcbcmac_cra_init(struct crypto=
_tfm *tfm)
>=20
>  	safexcel_ahash_cra_init(tfm);
>  	ctx->kaes =3D crypto_alloc_cipher("aes", 0, 0);
> -	if (IS_ERR(ctx->kaes))
> -		return PTR_ERR(ctx->kaes);
>=20
> -	return 0;
> +	return PTR_ERR_OR_ZERO(ctx->kaes);
>  }
Thanks for spotting, but a similar patch has already been applied.
So this patch is obsolete now.

>=20
>  static void safexcel_xcbcmac_cra_exit(struct crypto_tfm *tfm)
> --
> 2.7.4


Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com