Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Hook, Gary" <Gary.Hook@amd.com>
To:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     "Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: [PATCH v2 1/2] crypto: ccp - Change a message to reflect status
 instead of failure
Thread-Topic: [PATCH v2 1/2] crypto: ccp - Change a message to reflect status
 instead of failure
Thread-Index: AQHViBWuWuW34VDWakCQjOR5yJQ1Ww==
Date:   Mon, 21 Oct 2019 13:44:37 +0000
Message-ID: <157166547584.28287.382040905784783121.stgit@taos>
References: <157166543871.28287.16899240336796713483.stgit@taos>
In-Reply-To: <157166543871.28287.16899240336796713483.stgit@taos>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.204.78.1]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: baf816b3-14db-454a-2b5e-08d7562cd070
x-ms-office365-filtering-ht: Tenant
x-ms-traffictypediagnostic: DM5PR12MB2582:
x-ld-processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM5PR12MB25821FB3C27A79C7661728D7FD690@DM5PR12MB2582.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 0197AFBD92
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(4636009)(39860400002)(346002)(396003)(376002)(136003)(366004)(189003)(199004)(25786009)(54906003)(6436002)(15650500001)(71200400001)(5660300002)(66946007)(64756008)(66446008)(66476007)(6916009)(86362001)(66556008)(71190400001)(52116002)(446003)(99286004)(76176011)(186003)(2351001)(2501003)(103116003)(486006)(66066001)(386003)(6506007)(26005)(4326008)(8936002)(256004)(9686003)(14444005)(6512007)(8676002)(305945005)(14454004)(316002)(478600001)(7736002)(2906002)(81156014)(81166006)(102836004)(3846002)(476003)(11346002)(6116002)(33716001)(6486002)(5640700003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB2582;H:DM5PR12MB1449.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: OuvL/AUYltfTxC76KVcnR+NdUmDBMFOXBmDpe5lv1gWQjntijAdE/4FLsKw/HcBIiL+CxDy+I5vAiKjWQjMk/St/jbAXw4DdHLMK+WTx/UyF2L7y5C9rO0GLPmBGCMIG7gKunahAKCpRyznjTW9yC1qB6XltKQk/5EJbI4D80ICCblDhgVghGt58KGCdGgga8sf318WOcGz54KEplYiWbW0apF/pzaDJPZGRy2BkrQfcjxE/yZ/yJG5+0xTjk9ExiNZIKO6G6S2FqxzHBWZwkwybXDucvOTEn8a0+JExMmC+1zIdqFklcYKXOCOotXIM1imUcRpACgBDYI7kxjeSX2E7AdwrsqAF4meC4balhznKoRxDFoQSzlpoJJx/SEaImqInSgLz1ne0emZpBe0qN1RMAkVpHmo7HcKWG+U71QrsqqF5iWbsCP/CePU2n4V1
Content-Type: text/plain; charset="us-ascii"
Content-ID: <61BFAB1A9F18FC4683CDF033579D224A@namprd12.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: baf816b3-14db-454a-2b5e-08d7562cd070
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2019 13:44:37.3195
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MJS5dMVD8XMWsHfxhY0xh92oEYCzqmWpweZ0IqOWh7QoR12JYEsQndoVRn0sUYXN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2582
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

If an AMD BIOS makes zero CCP queues available to the driver, the
device is unavailable and therefore can't be activated. When this
happens, report the status but don't report a (non-existent)
failure. The CCP will be unactivated.

Signed-off-by: Gary R Hook <gary.hook@amd.com>
---
 drivers/crypto/ccp/ccp-dev-v5.c |    2 +-
 drivers/crypto/ccp/ccp-dev.c    |   15 ++++++++++++---
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v=
5.c
index 57eb53b8ac21..2937ba3afb7b 100644
--- a/drivers/crypto/ccp/ccp-dev-v5.c
+++ b/drivers/crypto/ccp/ccp-dev-v5.c
@@ -854,7 +854,7 @@ static int ccp5_init(struct ccp_device *ccp)
=20
 	if (ccp->cmd_q_count =3D=3D 0) {
 		dev_notice(dev, "no command queues available\n");
-		ret =3D -EIO;
+		ret =3D 1;
 		goto e_pool;
 	}
=20
diff --git a/drivers/crypto/ccp/ccp-dev.c b/drivers/crypto/ccp/ccp-dev.c
index 73acf0fdb793..19ac509ed76e 100644
--- a/drivers/crypto/ccp/ccp-dev.c
+++ b/drivers/crypto/ccp/ccp-dev.c
@@ -641,18 +641,27 @@ int ccp_dev_init(struct sp_device *sp)
 		ccp->vdata->setup(ccp);
=20
 	ret =3D ccp->vdata->perform->init(ccp);
-	if (ret)
+	if (ret) {
+		/* A positive number means that the device cannot be initialized,
+		 * but no additional message is required.
+		 */
+		if (ret > 0)
+			goto e_quiet;
+
+		/* An unexpected problem occurred, and should be reported in the log */
 		goto e_err;
+	}
=20
 	dev_notice(dev, "ccp enabled\n");
=20
 	return 0;
=20
 e_err:
-	sp->ccp_data =3D NULL;
-
 	dev_notice(dev, "ccp initialization failed\n");
=20
+e_quiet:
+	sp->ccp_data =3D NULL;
+
 	return ret;
 }
=20