Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1571445697-33824-1-git-send-email-tiantao6@huawei.com>
In-Reply-To: <1571445697-33824-1-git-send-email-tiantao6@huawei.com>
From:   Gilad Ben-Yossef <gilad@benyossef.com>
Date:   Thu, 24 Oct 2019 16:42:26 +0300
Message-ID: <CAOtvUMdw=N3ky-z2T4gJDM6YeGp2ir6d=ZtTrpLoK7g89-x+1g@mail.gmail.com>
Subject: Re: [PATCH v2] crypto: fix comparison of unsigned expression warning
To:     Tian Tao <tiantao6@huawei.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        David Miller <davem@davemloft.net>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        linuxarm@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Sat, Oct 19, 2019 at 3:44 AM Tian Tao <tiantao6@huawei.com> wrote:
>
> This patch fixes the following warnings:
> drivers/crypto/ccree/cc_aead.c:630:5-12: WARNING: Unsigned expression
> compared with zero: seq_len > 0
>
> Signed-off-by: Tian Tao <tiantao6@huawei.com>


Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>

Thanks,
Gilad

>
> v2:
> change hmac_setkey() return type to unsigned int to fix the warning.
> ---
>  drivers/crypto/ccree/cc_aead.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccree/cc_aead.c b/drivers/crypto/ccree/cc_aea=
d.c
> index d3e8faa..64d318d 100644
> --- a/drivers/crypto/ccree/cc_aead.c
> +++ b/drivers/crypto/ccree/cc_aead.c
> @@ -293,7 +293,8 @@ static unsigned int xcbc_setkey(struct cc_hw_desc *de=
sc,
>         return 4;
>  }
>
> -static int hmac_setkey(struct cc_hw_desc *desc, struct cc_aead_ctx *ctx)
> +static unsigned int hmac_setkey(struct cc_hw_desc *desc,
> +                               struct cc_aead_ctx *ctx)
>  {
>         unsigned int hmac_pad_const[2] =3D { HMAC_IPAD_CONST, HMAC_OPAD_C=
ONST };
>         unsigned int digest_ofs =3D 0;
> --
> 2.7.4
>


--=20
Gilad Ben-Yossef
Chief Coffee Drinker

values of =CE=B2 will give rise to dom!