Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 20/27] crypto: qce - switch to skcipher API
To:     Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        linux-crypto@vger.kernel.org
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Biggers <ebiggers@google.com>,
        linux-arm-kernel@lists.infradead.org
References: <20191024132345.5236-1-ard.biesheuvel@linaro.org>
 <20191024132345.5236-21-ard.biesheuvel@linaro.org>
From:   Stanimir Varbanov <stanimir.varbanov@linaro.org>
Message-ID: <d587463d-2aa5-1ec3-ab0d-f4a985ec5551@linaro.org>
Date:   Sun, 27 Oct 2019 11:51:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191024132345.5236-21-ard.biesheuvel@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Hi Ard,

Thanks for the patch!

On 10/24/19 4:23 PM, Ard Biesheuvel wrote:
> Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
> dated 20 august 2015 introduced the new skcipher API which is supposed to
> replace both blkcipher and ablkcipher. While all consumers of the API have
> been converted long ago, some producers of the ablkcipher remain, forcing
> us to keep the ablkcipher support routines alive, along with the matching
> code to expose [a]blkciphers via the skcipher API.
> 
> So switch this driver to the skcipher API, allowing us to finally drop the
> blkcipher code in the near future.
> 
> Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  drivers/crypto/qce/Makefile                     |   2 +-
>  drivers/crypto/qce/cipher.h                     |   8 +-
>  drivers/crypto/qce/common.c                     |  12 +-
>  drivers/crypto/qce/common.h                     |   3 +-
>  drivers/crypto/qce/core.c                       |   2 +-
>  drivers/crypto/qce/{ablkcipher.c => skcipher.c} | 172 ++++++++++----------
>  6 files changed, 100 insertions(+), 99 deletions(-)

Reviewed-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

-- 
regards,
Stan