Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191027154747.14844-1-chunkeey@gmail.com>
In-Reply-To: <20191027154747.14844-1-chunkeey@gmail.com>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Mon, 28 Oct 2019 07:07:35 +0100
Message-ID: <CAKv+Gu_NSSy7Ea9X83ZDW=yqik_pcksGe7T8+vxdeZRKz_midg@mail.gmail.com>
Subject: Re: [PATCH] crypto: amcc - restore CRYPTO_AES dependency
To:     Christian Lamparter <chunkeey@gmail.com>
Cc:     "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Sun, 27 Oct 2019 at 16:47, Christian Lamparter <chunkeey@gmail.com> wrote:
>
> This patch restores the CRYPTO_AES dependency. This is
> necessary since some of the crypto4xx driver provided
> modes need functioning software fallbacks for
> AES-CTR/CCM and GCM.
>
> Fixes: da3e7a9715ea ("crypto: amcc - switch to AES library for GCM key derivation")
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  drivers/crypto/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 23d3fd97f678..06c8e3e1c48a 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -332,6 +332,7 @@ config CRYPTO_DEV_PPC4XX
>         depends on PPC && 4xx
>         select CRYPTO_HASH
>         select CRYPTO_AEAD
> +       select CRYPTO_AES
>         select CRYPTO_LIB_AES
>         select CRYPTO_CCM
>         select CRYPTO_CTR
> --
> 2.24.0.rc1
>