Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 24/27] crypto: talitos - switch to skcipher API
To:     Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc:     "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Biggers <ebiggers@google.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
References: <20191024132345.5236-1-ard.biesheuvel@linaro.org>
 <20191024132345.5236-25-ard.biesheuvel@linaro.org>
 <74d5c30d-d842-5bdb-ebb8-2aa47ffb5e8d@c-s.fr>
 <CAKv+Gu8V57Z2WixfYZSdT+rqsobqDYZ-Hyer6Aq9khUNeUsxmQ@mail.gmail.com>
 <be890dfd-a1aa-86e1-b1c7-99b72ad137d0@c-s.fr>
 <CAKv+Gu98fsPOZ3reGs6wXd+hzNa_pdVZ6+XDFoXhey7C39sfFw@mail.gmail.com>
From:   Christophe Leroy <christophe.leroy@c-s.fr>
Message-ID: <63c941df-ae15-733f-3b0b-35fc0ce6af51@c-s.fr>
Date:   Mon, 28 Oct 2019 11:36:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu98fsPOZ3reGs6wXd+hzNa_pdVZ6+XDFoXhey7C39sfFw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk


Le 28/10/2019 à 07:20, Ard Biesheuvel a écrit :
> On Sun, 27 Oct 2019 at 14:05, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>>
>>
>>
>> Le 27/10/2019 à 12:05, Ard Biesheuvel a écrit :
>>> On Sun, 27 Oct 2019 at 11:45, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>>>>
>>>>
>>>>
>>>> Le 24/10/2019 à 15:23, Ard Biesheuvel a écrit :
>>>>> Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
>>>>> dated 20 august 2015 introduced the new skcipher API which is supposed to
>>>>> replace both blkcipher and ablkcipher. While all consumers of the API have
>>>>> been converted long ago, some producers of the ablkcipher remain, forcing
>>>>> us to keep the ablkcipher support routines alive, along with the matching
>>>>> code to expose [a]blkciphers via the skcipher API.
>>>>>
>>>>> So switch this driver to the skcipher API, allowing us to finally drop the
>>>>> blkcipher code in the near future.
>>>>>
>>>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>>
>>>> With this series, I get the following Oops at boot:
>>>>
>>>
>>> Thanks for the report.
>>>
>>> Given that the series only modifies ablkcipher implementations, it is
>>> rather curious that the crash occurs in ahash_init(). Can you confirm
>>> that the crash does not occur with this patch reverted?
>>
>> Yes I confirm.
>>
>> You changed talitos_cra_init_ahash(). talitos_init_common() is not
>> called anymore. I think that's the reason.
>>
> 
> Thanks a lot for digging into this
> 
> Does this fix things for you?

Yes it does.
Thanks.
Christophe

> 
> index c29f8c02ea05..d71d65846e47 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -3053,7 +3053,7 @@ static int talitos_cra_init_ahash(struct crypto_tfm *tfm)
>          crypto_ahash_set_reqsize(__crypto_ahash_cast(tfm),
>                                   sizeof(struct talitos_ahash_req_ctx));
> 
> -       return 0;
> +       return talitos_init_common(ctx, talitos_alg);
>   }
> 
>   static void talitos_cra_exit(struct crypto_tfm *tfm)
>