Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 30 Oct 2019 09:08:19 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     John Fastabend <john.fastabend@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>, davem@davemloft.net,
        glider@google.com, herbert@gondor.apana.org.au,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        syzkaller-bugs@googlegroups.com,
        syzbot <syzbot+9e3b178624a8a2f8fa28@syzkaller.appspotmail.com>
Subject: Re: [net/tls] Re: KMSAN: uninit-value in aes_encrypt (2)
Message-ID: <20191030090819.27b8c169@cakuba.hsd1.ca.comcast.net>
In-Reply-To: <20191024172353.GA740@sol.localdomain>
References: <00000000000065ef5f0595aafe71@google.com>
        <20191024172353.GA740@sol.localdomain>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Thu, 24 Oct 2019 10:23:53 -0700, Eric Biggers wrote:
> [+TLS maintainers]
>=20
> This is a net/tls bug, and probably a duplicate of:
>=20
> KMSAN: uninit-value in gf128mul_4k_lle (3)
> 	https://lkml.kernel.org/linux-crypto/000000000000bf2457057b5ccda3@google=
.com/T/#u
> =09
> KMSAN: uninit-value in aesti_encrypt
> 	https://lkml.kernel.org/linux-crypto/000000000000a97a15058c50c52e@google=
.com/T/#u
>=20
> See analysis from Alexander Potapenko here which shows that uninitialized=
 memory
> is being passed from TLS subsystem into crypto subsystem:
>=20
> 	https://lkml.kernel.org/linux-crypto/CAG_fn=3DUGCoDk04tL2vB981JmXgo6+-RU=
PmrTa3dSsK5UbZaTjA@mail.gmail.com/
>=20
> That was a year ago, with C reproducer, and I've sent several reminders f=
or this
> already.  What's the ETA on a fix?  Or is TLS subsystem de facto unmainta=
ined?

Re: maintainers it may actually be that the bug is so old the people
who pay attention weren't in the MAINTAINERS yet ;) That'd explain why
Alexander didn't CC us.

Fix posted now:

net/tls: fix sk_msg trim on fallback to copy mode

=F0=9F=A4=9E