Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp239771ybx; Fri, 1 Nov 2019 02:44:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcYWLNyslL4biyJqYPpIGLduJPlUzV10sR6vc26aFJz8h95mdrsSbsLOtLJmlnT51Yh/jb X-Received: by 2002:a17:906:2cd2:: with SMTP id r18mr8781252ejr.282.1572601481048; Fri, 01 Nov 2019 02:44:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572601481; cv=none; d=google.com; s=arc-20160816; b=kAoK+4Dl9tc8eIQkk8og44PtENV+5MVB8lvXU0ZbzyHcwA/+zYE9zCVJXkF0qIUjDj V7IYG7DHUGsuZUlsYhXctBnFuaCscCCTCq9ym6W/YIjtt5MOkDsPhwSKOB3c/NWFRhCe DiyDWVTBR5rUxV2uk0LN32UL7tvatSEKtvb4GqaB/ET/u4pjILWmv3F/exElcdWDGil9 Nx2JWSHabpNKj3OWWXYwIqVr/mAxFQe722B51wN+cwbesR5EvkFd1oO47ifz0528XPet aXFnCtD+EZIln3WTk9SbOHeDykNu3iBltU2ObUHBJk6zq8BjB0+Kriha4UQ6GI1cmx9/ 0ntQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Zc1xL1xnQe5eHAVEAStwj/KZh9ZFduC/h4hGXHWfZwY=; b=Mnw1SPRBVV04PcX51G94OIDtTn0lN1Xo24e6+3Q635GiO5Bih2I1U4FIKIuLZEfLJB dhZGwCx5jiM49zJGm526SvqAU/gEtNAfbTMDa3We5j9i2mplayjQKPMuogZ5FkFs/A3K on6GedxaO1j/DV4bqztVsCl2cIAWGDzX/3sGM5ZpkTebdIeUPXA4+SdGYbJ1JzhMall2 whEyRBXsPmeUmvsiG2wwr8l8MZoaGFBf64ZzwkluZf5HuiReIrfUpxQXgzxpMB9NVU8O /Hx5nM0UVHH7U2y64IGB+dgGSOzJZL/xWZGNaBI1z9F505684ZDxrlPWv6FNxHSGgZ64 BLCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NkgdlrwT; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5si405955eds.175.2019.11.01.02.44.16; Fri, 01 Nov 2019 02:44:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NkgdlrwT; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726771AbfKAJip (ORCPT + 99 others); Fri, 1 Nov 2019 05:38:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:42456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbfKAJip (ORCPT ); Fri, 1 Nov 2019 05:38:45 -0400 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2174D21734; Fri, 1 Nov 2019 09:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572601123; bh=i6GifndF/sL8RuzHU+FjbfR+1Pi9deMws6Ukyp7wWhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NkgdlrwTrf8r7CQpKCTrDaCfT0hEOKdhpSKZw5wrezwStgtDp1lE/cS3vxBHTP5oM sez5Wyo4U4ctHjXSDYlIDmq1sen+wgSfdU+Y4uTJa1EzzJIxpb9u8YJBN2B3n4PmNC 47f4vaB5xdcU0N3ZKGuj+kWYAC/Iv54qifWtBiX8= Date: Fri, 1 Nov 2019 10:02:44 +0100 From: Maxime Ripard To: Herbert Xu Cc: Corentin Labbe , catalin.marinas@arm.com, davem@davemloft.net, linux@armlinux.org.uk, mark.rutland@arm.com, robh+dt@kernel.org, wens@csie.org, will@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v6 00/11] crypto: add sun8i-ce driver for Allwinner crypto engine Message-ID: <20191101090244.hkur2yk7m4irnkuz@hendrix> References: <20191023200513.22630-1-clabbe.montjoie@gmail.com> <20191101060914.sv7g5ipygagzz4ed@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5bjlmdtlusbphfx7" Content-Disposition: inline In-Reply-To: <20191101060914.sv7g5ipygagzz4ed@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org --5bjlmdtlusbphfx7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 01, 2019 at 02:09:14PM +0800, Herbert Xu wrote: > On Wed, Oct 23, 2019 at 10:05:02PM +0200, Corentin Labbe wrote: > > Hello > > > > This patch serie adds support for the Allwinner crypto engine. > > The Crypto Engine is the third generation of Allwinner cryptogaphic offloader. > > The first generation is the Security System already handled by the > > sun4i-ss driver. > > The second is named also Security System and is present on A80 and A83T > > SoCs, originaly this driver supported it also, but supporting both IP bringing > > too much complexity and another driver (sun8i-ss) will came for it. > > > > For the moment, the driver support only DES3/AES in ECB/CBC mode. > > Patchs for CTR/CTS/XTS, RSA and RNGs will came later. > > > > This serie is tested with CRYPTO_MANAGER_EXTRA_TESTS > > and tested on: > > sun50i-a64-bananapi-m64 > > sun50i-a64-pine64-plus > > sun50i-h5-libretech-all-h3-cc > > sun50i-h6-pine-h64 > > sun8i-h2-plus-libretech-all-h3-cc > > sun8i-h2-plus-orangepi-r1 > > sun8i-h2-plus-orangepi-zero > > sun8i-h3-libretech-all-h3-cc > > sun8i-h3-orangepi-pc > > sun8i-r40-bananapi-m2-ultra > > > > DT and defconfig will go thru the mripard tree > > > > Regards > > > > Changes since v5: > > - fixed uninitialized err in sun8i_ce_allocate_chanlist (reported by lkp@intel.com/dan.carpenter@oracle.com) > > > > Changes since v4: > > - fixed some typos in kconfig > > - made sun8i_ce_pm_ops static > > - Use devm_platform_ioremap_resource > > > > Changes since v3: > > - removed need of reset-names > > - made reset mandatory > > > > Changes since v2: > > - changed additionalproperties > > - splited fallbacks functions out of sun8i_ce_cipher() > > - changed variant "model" to "has_t_dlen_in_bytes" > > - splited sun8i_ce_register_algs/sun8i_ce_get_clks out of sun8i_ce_probe() > > > > Changes since v1: > > - Add sun4i-ss to allwinner directory > > - Cleaned variant structure > > - Renamed clock name from ahb to bus (and mbus to ram) > > - Fixed DT bindings problem reported by mripard > > - Cleaned unneeded status = "" in R40 DT > > - Removed old unnecessary interrupt_names in A64 DT > > - Added arm64 defconfig > > - Added support for PM functions > > - Splitted probe functions > > - Reworked clock settings > > - made reset mandatory > > > > Corentin Labbe (11): > > crypto: Add allwinner subdirectory > > crypto: Add Allwinner sun8i-ce Crypto Engine > > dt-bindings: crypto: Add DT bindings documentation for sun8i-ce Crypto > > Engine > > ARM: dts: sun8i: R40: add crypto engine node > > ARM: dts: sun8i: H3: Add Crypto Engine node > > ARM64: dts: allwinner: sun50i: Add Crypto Engine node on A64 > > ARM64: dts: allwinner: sun50i: Add crypto engine node on H5 > > ARM64: dts: allwinner: sun50i: Add Crypto Engine node on H6 > > sunxi_defconfig: add new Allwinner crypto options > > arm64: defconfig: add new Allwinner crypto options > > crypto: sun4i-ss: Move to Allwinner directory > > > > .../bindings/crypto/allwinner,sun8i-ce.yaml | 88 +++ > > MAINTAINERS | 4 +- > > arch/arm/boot/dts/sun8i-h3.dtsi | 9 + > > arch/arm/boot/dts/sun8i-r40.dtsi | 9 + > > arch/arm/configs/sunxi_defconfig | 2 + > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 + > > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 9 + > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 9 + > > arch/arm64/configs/defconfig | 2 + > > drivers/crypto/Kconfig | 28 +- > > drivers/crypto/Makefile | 2 +- > > drivers/crypto/allwinner/Kconfig | 60 ++ > > drivers/crypto/allwinner/Makefile | 2 + > > .../{sunxi-ss => allwinner/sun4i-ss}/Makefile | 0 > > .../sun4i-ss}/sun4i-ss-cipher.c | 0 > > .../sun4i-ss}/sun4i-ss-core.c | 0 > > .../sun4i-ss}/sun4i-ss-hash.c | 0 > > .../sun4i-ss}/sun4i-ss-prng.c | 0 > > .../sun4i-ss}/sun4i-ss.h | 0 > > drivers/crypto/allwinner/sun8i-ce/Makefile | 2 + > > .../allwinner/sun8i-ce/sun8i-ce-cipher.c | 434 +++++++++++ > > .../crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 676 ++++++++++++++++++ > > drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h | 254 +++++++ > > 23 files changed, 1570 insertions(+), 29 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml > > create mode 100644 drivers/crypto/allwinner/Kconfig > > create mode 100644 drivers/crypto/allwinner/Makefile > > rename drivers/crypto/{sunxi-ss => allwinner/sun4i-ss}/Makefile (100%) > > rename drivers/crypto/{sunxi-ss => allwinner/sun4i-ss}/sun4i-ss-cipher.c (100%) > > rename drivers/crypto/{sunxi-ss => allwinner/sun4i-ss}/sun4i-ss-core.c (100%) > > rename drivers/crypto/{sunxi-ss => allwinner/sun4i-ss}/sun4i-ss-hash.c (100%) > > rename drivers/crypto/{sunxi-ss => allwinner/sun4i-ss}/sun4i-ss-prng.c (100%) > > rename drivers/crypto/{sunxi-ss => allwinner/sun4i-ss}/sun4i-ss.h (100%) > > create mode 100644 drivers/crypto/allwinner/sun8i-ce/Makefile > > create mode 100644 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > > create mode 100644 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > > create mode 100644 drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h > > Patches 1,2,11 applied. Thanks. Applied the rest, thanks! Maxime --5bjlmdtlusbphfx7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXbv0tAAKCRDj7w1vZxhR xaasAQCJBzDd1Ng5hMbRyaEoYsi7T5XVjtN6D13l8WAa9f/XfAEAuDL5vK17rxNc TlvIkUnOEN/L2K1HT+rnj0Zt9aGkxww= =Jw04 -----END PGP SIGNATURE----- --5bjlmdtlusbphfx7--