Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp780299ybx; Tue, 5 Nov 2019 05:31:25 -0800 (PST) X-Google-Smtp-Source: APXvYqw5BAZfVnoZQaGwHdekwp/geAnhmkLRzBm6irzwMyRxKad3R2+8l5zzRIBse+2ncphlKlPn X-Received: by 2002:a17:907:216e:: with SMTP id rl14mr17318858ejb.291.1572960684934; Tue, 05 Nov 2019 05:31:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572960684; cv=none; d=google.com; s=arc-20160816; b=Y/E2hrQxPRFr7BnfiHFo3tKgod5hzyevLKvxPyFllBw+OXoyfI4Wn/ar3yndLK+VlI UHb6PDIgbDbZbawvOhN05mNniVQ6kw6k4rthlushVp8Q2wO5jiXMZr9ya15yhp3CGKGE CMqNHmPaNCgWOdcqyLBbjZf30hyT0Ck72w836sOY9I0b3rm/6GBOmv8dzCVBui9AiKKj zoFW1z5eCf6ZlaHiUlO87US5G0DxiBMi+g9IfbEDiIv3A2sUWDl76Hl9HHbc55wjHMg5 IfM8Dnmb13OVcM3ckWizIJyd/wYyLi9JksmpfTBeoL0rP9orbQqRZQJLGwP/bwi311A2 Xc5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cerv8xdhPqyHB4z9g1ko5bNrNNqxba0vf3UALjFdcyM=; b=OPQMGI47Bcm4dTWVQOUG7L0aZNgb9kYu36+9z6OJs7eF883Hz0GnqiFEFETt87MuGz u13Xfl7mxNkBOPtl2wKjnI9J5tQISvKOF4oPCfOs844j6JCL7xe+XNdvWmbUOVNNvAxB /ulF7o7f5bY0OqkiXroa6kKAalfO3yMaVG+CkMs2C+ZIM8tDw4gpssyjPeTPN5llNoat B1MBsz9oFz2vxUFJaAPEXR1PxW4CwS3IYeyv2DfhbY0vh8KlYDrKVNClBjzVxFginMYb ZrHwWbQh8cjI5o8LRINk+S7gDcDGgarYUfrkrwaGgw0QDrMDjy6eZ8nMq/WHKExZKXjn h6Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wvgyWKgx; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c25si1084535eja.24.2019.11.05.05.31.00; Tue, 05 Nov 2019 05:31:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wvgyWKgx; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389213AbfKEN3e (ORCPT + 99 others); Tue, 5 Nov 2019 08:29:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:47750 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389198AbfKEN3e (ORCPT ); Tue, 5 Nov 2019 08:29:34 -0500 Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr [92.154.90.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D4E02190F; Tue, 5 Nov 2019 13:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572960573; bh=9siA7yMMHrQQj/tFGDxCU5tWG0e1feLftg/584iuhrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wvgyWKgx8DIzqM778cU21vMMfHt7IaAmzxjZh4Ohybc2fX92soAStucb93gfewoVk yrOrhewkzKyEchXzCDKRZY1FIHOgsrF1bEgtnVh/VH1DN4114MWDkyUuXVgxzkB3EN Q76Y0hOt0DY53u6pXhBdyt9U5AVA6Qvu687fewV8= From: Ard Biesheuvel To: linux-crypto@vger.kernel.org Cc: Ard Biesheuvel , Herbert Xu , "David S. Miller" , Eric Biggers , linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 27/29] crypto: nx - remove stale comment referring to the blkcipher walk API Date: Tue, 5 Nov 2019 14:28:24 +0100 Message-Id: <20191105132826.1838-28-ardb@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191105132826.1838-1-ardb@kernel.org> References: <20191105132826.1838-1-ardb@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org These drivers do not use either the deprecated blkcipher or the current skcipher walk API, so this comment must refer to a previous state of the driver that no longer exists. So drop the comments. Signed-off-by: Ard Biesheuvel --- drivers/crypto/nx/nx-aes-ccm.c | 5 ----- drivers/crypto/nx/nx-aes-gcm.c | 5 ----- 2 files changed, 10 deletions(-) diff --git a/drivers/crypto/nx/nx-aes-ccm.c b/drivers/crypto/nx/nx-aes-ccm.c index 84fed736ed2e..4c9362eebefd 100644 --- a/drivers/crypto/nx/nx-aes-ccm.c +++ b/drivers/crypto/nx/nx-aes-ccm.c @@ -525,11 +525,6 @@ static int ccm_aes_nx_decrypt(struct aead_request *req) return ccm_nx_decrypt(req, req->iv, req->assoclen); } -/* tell the block cipher walk routines that this is a stream cipher by - * setting cra_blocksize to 1. Even using blkcipher_walk_virt_block - * during encrypt/decrypt doesn't solve this problem, because it calls - * blkcipher_walk_done under the covers, which doesn't use walk->blocksize, - * but instead uses this tfm->blocksize. */ struct aead_alg nx_ccm_aes_alg = { .base = { .cra_name = "ccm(aes)", diff --git a/drivers/crypto/nx/nx-aes-gcm.c b/drivers/crypto/nx/nx-aes-gcm.c index 898220e159d3..19c6ed5baea4 100644 --- a/drivers/crypto/nx/nx-aes-gcm.c +++ b/drivers/crypto/nx/nx-aes-gcm.c @@ -467,11 +467,6 @@ static int gcm4106_aes_nx_decrypt(struct aead_request *req) return gcm_aes_nx_crypt(req, 0, req->assoclen - 8); } -/* tell the block cipher walk routines that this is a stream cipher by - * setting cra_blocksize to 1. Even using blkcipher_walk_virt_block - * during encrypt/decrypt doesn't solve this problem, because it calls - * blkcipher_walk_done under the covers, which doesn't use walk->blocksize, - * but instead uses this tfm->blocksize. */ struct aead_alg nx_gcm_aes_alg = { .base = { .cra_name = "gcm(aes)", -- 2.20.1