Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To:     Antoine Tenart <antoine.tenart@bootlin.com>,
        Pascal van Leeuwen <pascalvanl@gmail.com>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH] crypto: inside-secure - Fixed authenc w/ (3)DES fails on
 Macchiatobin
Thread-Topic: [PATCH] crypto: inside-secure - Fixed authenc w/ (3)DES fails on
 Macchiatobin
Thread-Index: AQHVlgkEZiAwJ1uEqUmpCLW+07a2uqeA86EAgAAAOZA=
Date:   Fri, 8 Nov 2019 08:40:29 +0000
Message-ID: <MN2PR20MB2973F06785376947972AA751CA7B0@MN2PR20MB2973.namprd20.prod.outlook.com>
References: <1573199165-8279-1-git-send-email-pvanleeuwen@verimatrix.com>
 <20191108083810.GB111259@kwain>
In-Reply-To: <20191108083810.GB111259@kwain>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: verimatrix.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fecac87e-9cf4-4335-e224-08d764274f94
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2019 08:40:29.3066
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dcb260f9-022d-4495-8602-eae51035a0d0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Azu2++Y+y2aGlIZJcpedfJDGygxmNouf3idYM2CrehA4rob/swrCME93MoySw4XsMvt0iwlFQ7jYp0VwJMAm/CqWoUh+1piTcfItFlc1pAQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR20MB2669
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.=
org> On Behalf Of
> Antoine Tenart
> Sent: Friday, November 8, 2019 9:38 AM
> To: Pascal van Leeuwen <pascalvanl@gmail.com>
> Cc: linux-crypto@vger.kernel.org; antoine.tenart@bootlin.com; herbert@gon=
dor.apana.org.au;
> davem@davemloft.net; Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
> Subject: Re: [PATCH] crypto: inside-secure - Fixed authenc w/ (3)DES fail=
s on Macchiatobin
>=20
> Hi Pascal,
>=20
> On Fri, Nov 08, 2019 at 08:46:05AM +0100, Pascal van Leeuwen wrote:
> > Fixed 2 copy-paste mistakes made during commit 13a1bb93f7b1c9 ("crypto:
> > inside-secure - Fixed warnings on inconsistent byte order handling")
> > that caused authenc w/ (3)DES to consistently fail on Macchiatobin (but
> > strangely work fine on x86+FPGA??).
> > Now fully tested on both platforms.
>=20
> Can you add a Fixes: tag?
>=20
Sure I can :-) If I know what I should put in such a Fixes: tag?
(I'm off Googling now, but a response here might be faster :-)

> Thanks!
> Antoine
>=20
> > Signed-off-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
> > ---
> >  drivers/crypto/inside-secure/safexcel_cipher.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/c=
rypto/inside-
> secure/safexcel_cipher.c
> > index 98f9fc6..c029956 100644
> > --- a/drivers/crypto/inside-secure/safexcel_cipher.c
> > +++ b/drivers/crypto/inside-secure/safexcel_cipher.c
> > @@ -405,7 +405,8 @@ static int safexcel_aead_setkey(struct crypto_aead =
*ctfm, const u8
> *key,
> >
> >  	if (priv->flags & EIP197_TRC_CACHE && ctx->base.ctxr_dma) {
> >  		for (i =3D 0; i < keys.enckeylen / sizeof(u32); i++) {
> > -			if (le32_to_cpu(ctx->key[i]) !=3D aes.key_enc[i]) {
> > +			if (le32_to_cpu(ctx->key[i]) !=3D
> > +			    ((u32 *)keys.enckey)[i]) {
> >  				ctx->base.needs_inv =3D true;
> >  				break;
> >  			}
> > @@ -459,7 +460,7 @@ static int safexcel_aead_setkey(struct crypto_aead =
*ctfm, const u8
> *key,
> >
> >  	/* Now copy the keys into the context */
> >  	for (i =3D 0; i < keys.enckeylen / sizeof(u32); i++)
> > -		ctx->key[i] =3D cpu_to_le32(aes.key_enc[i]);
> > +		ctx->key[i] =3D cpu_to_le32(((u32 *)keys.enckey)[i]);
> >  	ctx->key_len =3D keys.enckeylen;
> >
> >  	memcpy(ctx->ipad, &istate.state, ctx->state_sz);
> > --
> > 1.8.3.1
> >
>=20
> --
> Antoine T=E9nart, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com


Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com