Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2204546ybx; Fri, 8 Nov 2019 01:19:55 -0800 (PST) X-Google-Smtp-Source: APXvYqyqeIyOeEh7pMW8+asXJi2L74hLVSQC7S3NLY0VCAh2dxOyIpyqXi7L6g6x+V2uPUSmcFgy X-Received: by 2002:a17:906:c9d8:: with SMTP id hk24mr7576481ejb.159.1573204795646; Fri, 08 Nov 2019 01:19:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573204795; cv=none; d=google.com; s=arc-20160816; b=uKdZaqiioK1tO3IkDPsAyEUXZNhg91vTTf4gFy7kNOcAIItnRr4j/SyXwnZnKQDJi+ CWa8ATtt0BOsjLgporqQxkYo5e6jr7LwYzItvRGHoT+OBQmcJ1L80XTsH0VtGvCyK1LA b6KD/4xcUA/KVTTD0wwLTnNkI7gXF5/hc9jSaSSMMjnfb5/EdLd9Fnp6U9YYMh7v1Z6z lTrE/+c17FGnefMCUW2EaIy9saa5q6LTbZcpnUaLe9VxX1xz1gMWQP2YFgX0hlDqSiOC t8q9BY4oNqOaBFy56kPturDsVVAtkE42anz9EM9vkJ9ul6Ec5DZ1S8JVkHtHYxDRa+iG Q/1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ONwmhTY9viB9Btc6JNzyGPLfooxHfIjNnvQ8Ut1npE0=; b=hwTwPT8H3IO1OtgSgIJiKjI3vxyo2QMw8RnhirkF/80AlEV2in4PbSoecsRZvZnvzX Bmsfw5Fyvyr8IlXN5UoCRENd2JQYV4sseA98f5BxHbnayHCFWpMGiuE2qkFh8idd7ejE vI8JxUKrywqmi/6O848JrtbM3IodjQ25+sdvRNWEvj3IM/xu4/e6bcxLWJqxDhtgYCer VjBVXNiW5FBc0DzEE/vc81sd0MUz9GRYlTa1u/BPFnKaxxuy2KL5DJrsS1E1lLXcIETa tUAWgaIvh4pbp10isjula+4xQfdhcWEP14IaBuLRsAVhW2lEoUP4eRKxfOw1O7Rrppez G20Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x50si4019478eda.155.2019.11.08.01.19.12; Fri, 08 Nov 2019 01:19:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730733AbfKHJQV (ORCPT + 99 others); Fri, 8 Nov 2019 04:16:21 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:36866 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730281AbfKHJQV (ORCPT ); Fri, 8 Nov 2019 04:16:21 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iT0NG-00020V-C1; Fri, 08 Nov 2019 17:16:10 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iT0NE-0002Ll-H0; Fri, 08 Nov 2019 17:16:08 +0800 Date: Fri, 8 Nov 2019 17:16:08 +0800 From: Herbert Xu To: Tero Kristo Cc: Gilad Ben-Yossef , David Miller , Linux Crypto Mailing List , Ard Biesheuvel , linux-omap@vger.kernel.org, Linux ARM Subject: Re: [PATCH 09/10] crypto: add timeout to crypto_wait_req Message-ID: <20191108091608.i5fxt2vu2nwrybgn@gondor.apana.org.au> References: <20191017122549.4634-1-t-kristo@ti.com> <20191017122549.4634-10-t-kristo@ti.com> <076f0bc6-ad04-9543-db02-d7c7060db036@ti.com> <20191108022759.GB1140@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 08, 2019 at 09:40:57AM +0200, Tero Kristo wrote: > > The problem is not detecting a hung task, the problem is determining what > caused the hang. Personally I don't care if the system dies if a crypto > accelerator self test has failed, as long as I get reported about the exact > nature of the failure. The failures are expected to happen only in > development phase of a crypto driver. > > With the timeout patch in place, I get reported what exact crypto test case > failed and I can focus my debug efforts on that one. If that's all you need then how about just making the wait killable? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt