Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1189506ybc; Sat, 16 Nov 2019 16:57:44 -0800 (PST) X-Google-Smtp-Source: APXvYqw2KBaBoTrZT2xNVyxF8J2nTEIB0nXSKQrDf2PcaGA5wDz+sKMN2RiFAPSKHKiaVLIVVej8 X-Received: by 2002:a17:906:5c06:: with SMTP id e6mr11060853ejq.195.1573952264860; Sat, 16 Nov 2019 16:57:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573952264; cv=none; d=google.com; s=arc-20160816; b=BzxHfWx1C3eWb7t4FYLBagkKz2xpSgoisgPXX8AnZlVk+FyrkNoxEykXg4zXYbcMdm lzIjUyPBQzFwqUDdzb1YqJFsSdGJAocKgUccHqfj248n0O1w/AWWKYCrV4aQTd+AIrk+ 2Vw2qGrjeLp2BoYsMIIKKrqyR+bZcM1kFgWLKNC8RC8mmighraEN6fygwd7npbND1fj8 SXcz364GalYsjmsYnU+zuhZ2aqi1M2ioEzudqIL+4N2fv70HwJ9cPFhwldK8DSsngK1A CsYUvKg5Ps/X3mI4UEdp18nr+N5WseKc32S1F4uAH0kWhR1SWc3SFshAc7VvO2J8nbTn mttg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=iDVu76ncMP4xl9zuYfCHL9h5M/5Eocz+2DVzQKo3e98=; b=V2xw5p5txjO0txLYMUrGhIjMHQgJ0QEv+qD4JKCF9GH1bH3PEx4ucDjJzPZgMa8IWH N0j1xkw2JcUHWLQupUzhmtcBvTL2leM29kWmOAVZhhzNJr93H2eO2t8RN0oS3IwkeMFt urRJDfkH73JeoC7UG4muwkLCE8a0xCzwgHiFkovb5XVy3/UUVRDAmhxLzzNBxq45Y5oH jtjuOXlT1GnGUnsK8xY68Y4vHq/izRQXP9Z60M1VtN9NpeXz9LAev85mH8WwjgzL922T EaX37YXrILhcoLWag2xwWIl80DS9ofYW3B0bjSxfYD1I5ydXisgE/sx+XfCQa9ZdsrdL 6bBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g3si8663184ejf.345.2019.11.16.16.57.09; Sat, 16 Nov 2019 16:57:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727691AbfKQA5F (ORCPT + 99 others); Sat, 16 Nov 2019 19:57:05 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:57446 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727685AbfKQA5F (ORCPT ); Sat, 16 Nov 2019 19:57:05 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iW8rv-0003Qn-TL; Sun, 17 Nov 2019 08:56:47 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iW8rp-00046T-AW; Sun, 17 Nov 2019 08:56:41 +0800 Date: Sun, 17 Nov 2019 08:56:41 +0800 From: Herbert Xu To: "Maciej S. Szmigiero" Cc: Stephen Boyd , Theodore Ts'o , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Andrzej Siewior , Keerthy , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] random: Don't freeze in add_hwgenerator_randomness() if stopping kthread Message-ID: <20191117005641.qgremf2lrj46qy4p@gondor.apana.org.au> References: <20191110135543.3476097-1-mail@maciej.szmigiero.name> <5dcee409.1c69fb81.f5027.48ad@mx.google.com> <415922ac-3c87-081c-6fdf-73fc97d0f397@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <415922ac-3c87-081c-6fdf-73fc97d0f397@maciej.szmigiero.name> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Nov 17, 2019 at 12:01:20AM +0100, Maciej S. Szmigiero wrote: > > If a reader (user space) task is frozen then it is no longer waiting > on this waitqueue - at least if I understand correctly how the freezer > works for user space tasks, that is by interrupting waits via a fake > signal. At this point I'm just going to revert the whole thing and we can sort it out in the next development cycle. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt