Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 16 Nov 2019 23:09:45 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
        Stephen Boyd <swboyd@chromium.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Keerthy <j-keerthy@ti.com>, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] random: Don't freeze in add_hwgenerator_randomness() if
 stopping kthread
Message-ID: <20191117040945.GB31360@mit.edu>
References: <20191110135543.3476097-1-mail@maciej.szmigiero.name>
 <5dcee409.1c69fb81.f5027.48ad@mx.google.com>
 <415922ac-3c87-081c-6fdf-73fc97d0f397@maciej.szmigiero.name>
 <20191117005641.qgremf2lrj46qy4p@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191117005641.qgremf2lrj46qy4p@gondor.apana.org.au>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Sun, Nov 17, 2019 at 08:56:41AM +0800, Herbert Xu wrote:
> On Sun, Nov 17, 2019 at 12:01:20AM +0100, Maciej S. Szmigiero wrote:
> >
> > If a reader (user space) task is frozen then it is no longer waiting
> > on this waitqueue - at least if I understand correctly how the freezer
> > works for user space tasks, that is by interrupting waits via a fake
> > signal.
> 
> At this point I'm just going to revert the whole thing and we can
> sort it out in the next development cycle.

Thanks, I hadn't planned on taking any /dev/random changes this cycle
because it had gotten too late and the ext4 tree had gotten unusually
busy.

						- Ted