Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1387219ybc; Sat, 16 Nov 2019 22:17:57 -0800 (PST) X-Google-Smtp-Source: APXvYqxGsU0e2334kqTo92OAjko+yv1LJu1upRUPhvVTNOPK4mBKOtQdvg/LyCFD5EZ9gNDqtz/2 X-Received: by 2002:a17:906:6403:: with SMTP id d3mr15992550ejm.258.1573971477576; Sat, 16 Nov 2019 22:17:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573971477; cv=none; d=google.com; s=arc-20160816; b=1K5AGQ6yjkHldsGDqY96xYaaHWGFqPoBNGCCOHViCklvvB7T0eTnKSUhP6ljuu1Q4b 04ZOOyxc8EInqqYjWP2Klm8DqLXnxYtUdE/X+MUuy7z0e/rYajPs9oBaswLUYQOoQSd3 NICAfE7pJt4tKkM97aCTtOO+NbbYgAuYMuAFwszipHEly6U8ewrhcHZjyGOnK2zMqrhr VGpPr+DKXt5sXupG/PGdMsjqvdG1gWDF3+7TwsxH+NF4nPGEEapfmeP36bzGfSHxGlPK uqpIl3ASBX1lRoGkA0fNKfhE77sL7tWujCRA7GQ4xGvZJ9q5CcwEtpvQYmi43JODND0T N8Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=EyNqLWyu6a7Cs2JPGUTSzAWG/6GCveav2mKSjBErowo=; b=GLJ5CzcvpTB5GfDJ7s7NkD4y0SW4RfHl33saazN7/p8Bq1MhFohXFlFXLUbWY3IzXq GqdnUTytrN3NxJhyZNlllwmtKBjkm6S/s6CTi+gW0wRn15R9aKfUsG/COXtpAwVHlWoL SlAAM0VdrYVrECYqdYpKEBcPwes+OqeQDfP47bbVa/5lY6/DvBbiW9+iWrH76rITp+/9 FGkbCZRGnqsWyhOZFxxuCZb1ycCTkkDWFJ06fC2WL+NnxJuECOYraxHdYpDPcLy0cQk5 TPjoQhaHVejp/083GYYscYAStJQukSreseL9poZeu8Taad8+/L+wPSaigT6AM28moPFn BlGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cgOwvPAx; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u17si10072625edd.276.2019.11.16.22.17.11; Sat, 16 Nov 2019 22:17:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cgOwvPAx; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725978AbfKQGPw (ORCPT + 99 others); Sun, 17 Nov 2019 01:15:52 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55736 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbfKQGPv (ORCPT ); Sun, 17 Nov 2019 01:15:51 -0500 Received: by mail-wm1-f65.google.com with SMTP id b11so13997058wmb.5; Sat, 16 Nov 2019 22:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EyNqLWyu6a7Cs2JPGUTSzAWG/6GCveav2mKSjBErowo=; b=cgOwvPAxaH/n63Wg25tXMcm2kFvQNkQ6C3fJxB75FISbd+/+3ZKYYQDA/WdV+ErTMW M+wkpYzIImb61DSmNWELZCAEWsgl6a78nnMyjddYQ7FKpQ/jFh3KK49qbmlNP7oBYvWh z0mYXOrDmM4n+Uq51brbWpFBr52bPV7shjiyJ4iQ0aeHhXphBe3P62AsVcLWmw/HfX0G 4lyjpCC7hEdBW4cwdVe/1AAL/Hl9hFFJpzu8DFSCeclPBX3jR1JXTtrq/GH6QdwNs3+9 tH7UqbWzA/qR4Pw7mwhIS2w+tY6KOe6Wy2QHhQG/iw//8Tz/nup9KrpKKRc++R1TMVLA TICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EyNqLWyu6a7Cs2JPGUTSzAWG/6GCveav2mKSjBErowo=; b=L/IjnV4E7EiwSbkbtyC2u0x+Z5g1FAKUcbZ2L5mv2odAih69h+9+WjqyQuokCDqHEK /vbde3CkqzGwsPlTzSBTdXpFPit19+Tbt3Rc6SofYSPIqxT+Y9Rb6RRaia5qZHw5A9Ek MKPuHd5+PTccM48x76H9IffWIt/aam+oz8aAx/ioU4uwMbpk10Mr2hpmQZK2SHKbl08G VwXtGyJryVkJeTNCkCzX/fLYndBLraHaf/GTcQ0LfLecxJxan1mb99h/IS54hs37GFFU 9FBCzS/gcECXYGW0ExA1VMtkaHc5uaDhsAN8olz8NvytoS4yD8vggzKszJ2qet387DWp UIvg== X-Gm-Message-State: APjAAAX4vbxmE9a3xOovYTUfV8NtJmE+YPnoiDWLXubjjKOlNz7LZmif 0H0hb0NQMZPSN4T/Km0Wi/NObKeQ4DKLmWNBvkQ= X-Received: by 2002:a7b:ce11:: with SMTP id m17mr24822936wmc.113.1573971349494; Sat, 16 Nov 2019 22:15:49 -0800 (PST) MIME-Version: 1.0 References: <20191105151353.6522-1-andrew.smirnov@gmail.com> In-Reply-To: From: Andrey Smirnov Date: Sat, 16 Nov 2019 22:15:36 -0800 Message-ID: Subject: Re: [PATCH 0/5] CAAM JR lifecycle To: Horia Geanta Cc: Vakul Garg , "linux-crypto@vger.kernel.org" , Chris Healy , Lucas Stach , Herbert Xu , Iuliana Prodan , dl-linux-imx , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Nov 13, 2019 at 11:25 AM Andrey Smirnov wrote: > > On Wed, Nov 13, 2019 at 10:57 AM Horia Geanta wrote: > > > > On 11/6/2019 5:19 PM, Andrey Smirnov wrote: > > > On Tue, Nov 5, 2019 at 11:27 PM Vakul Garg wrote: > > >> > > >> > > >> > > >>> -----Original Message----- > > >>> From: linux-crypto-owner@vger.kernel.org > >>> owner@vger.kernel.org> On Behalf Of Andrey Smirnov > > >>> Sent: Tuesday, November 5, 2019 8:44 PM > > >>> To: linux-crypto@vger.kernel.org > > >>> Cc: Andrey Smirnov ; Chris Healy > > >>> ; Lucas Stach ; Horia Geanta > > >>> ; Herbert Xu ; > > >>> Iuliana Prodan ; dl-linux-imx > >>> imx@nxp.com>; linux-kernel@vger.kernel.org > > >>> Subject: [PATCH 0/5] CAAM JR lifecycle > > >>> > > >>> Everyone: > > >>> > > >>> This series is a different approach to addressing the issues brought up in > > >>> [discussion]. This time the proposition is to get away from creating per-JR > > >>> platfrom device, move all of the underlying code into caam.ko and disable > > >>> manual binding/unbinding of the CAAM device via sysfs. Note that this series > > >>> is a rough cut intented to gauge if this approach could be acceptable for > > >>> upstreaming. > > >>> > > >>> Thanks, > > >>> Andrey Smirnov > > >>> > > >>> [discussion] lore.kernel.org/lkml/20190904023515.7107-13- > > >>> andrew.smirnov@gmail.com > > >>> > > >>> Andrey Smirnov (5): > > >>> crypto: caam - use static initialization > > >>> crypto: caam - introduce caam_jr_cbk > > >>> crypto: caam - convert JR API to use struct caam_drv_private_jr > > >>> crypto: caam - do not create a platform devices for JRs > > >>> crypto: caam - disable CAAM's bind/unbind attributes > > >>> > > >> > > >> To access caam jobrings from DPDK (user space drivers), we unbind job-ring's platform device from the kernel. > > >> What would be the alternate way to enable job ring drivers in user space? > > >> > > > > > > Wouldn't either building your kernel with > > > CONFIG_CRYPTO_DEV_FSL_CAAM_JR=n (this series doesn't handle that right > > > currently due to being a rough cut) or disabling specific/all JRs via > > > DT accomplish the same goal? > > > > > It's not a 1:1 match, the ability to move a ring to user space / VM etc. > > *dynamically* goes away. > > > > Wouldn't it be possible to do that dynamically using DT overlays? That > is "modprobe -r caam; ; modprobe caam"? > Or, alternatively, could adding a module parameter, say "jr_mask", to limit JRs controlled by the driver cover dynamic use case? Thanks, Andrey Smirnov