Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <3209f601ad0537a7ef01e2a752f022ccf8816210.camel@suse.de>
Subject: Re: [PATCH 3/3] ARM: dts: bcm2711: Enable HWRNG support
From:   Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To:     Stephen Brennan <stephen@brennan.io>
Cc:     Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Scott Branden <sbranden@broadcom.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-kernel@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
        linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
        Rob Herring <robh+dt@kernel.org>,
        bcm-kernel-feedback-list@broadcom.com,
        Stefan Wahren <wahrenst@gmx.net>,
        Matt Mackall <mpm@selenic.com>, Arnd Bergmann <arnd@arndb.de>,
        linux-crypto@vger.kernel.org
Date:   Mon, 18 Nov 2019 12:44:59 +0100
In-Reply-To: <20191118075807.165126-4-stephen@brennan.io>
References: <20191118075807.165126-1-stephen@brennan.io>
         <20191118075807.165126-4-stephen@brennan.io>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-BrzURT1nntfCQobYCsCl"
User-Agent: Evolution 3.34.1 
MIME-Version: 1.0
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk


--=-BrzURT1nntfCQobYCsCl
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Stephen,

On Sun, 2019-11-17 at 23:58 -0800, Stephen Brennan wrote:
> From: Stefan Wahren <wahrenst@gmx.net>
>=20
> This enables hardware random number generator support for the BCM2711
> on the Raspberry Pi 4 board.
>=20
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Signed-off-by: Stephen Brennan <stephen@brennan.io>
> ---
>  arch/arm/boot/dts/bcm2711.dtsi | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.d=
tsi
> index ac83dac2e6ba..2c19e5de284a 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -92,10 +92,9 @@ pm: watchdog@7e100000 {
>  		};
> =20
>  		rng@7e104000 {
> +			compatible =3D "brcm,bcm2711-rng200";
>  			interrupts =3D <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
> -
> -			/* RNG is incompatible with brcm,bcm2835-rng */
> -			status =3D "disabled";
> +			status =3D "okay";
>  		};
> =20
>  		uart2: serial@7e201400 {

We inherit the reg property from bcm283x.dtsi, on which we only define a si=
ze
of 0x10 bytes. I gather from the driver that iproc-rng200's register space =
is
at least 0x28 bytes big. We should also update the 'reg' property to:

	reg =3D <0x7e104000 0x28>;

Regards,
Nicolas


--=-BrzURT1nntfCQobYCsCl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl3ShDsACgkQlfZmHno8
x/42dQgAiWoADYCp4IVFQLfny8DRGulI2ckkAswc80iZXIZSayMSqYsAogWqMDq1
IqOc4PUpzunlVDayHHLM4gxhvPZ+vVPbyQocAITnMo+kYw+CMdRKiwVSYw1ISuMx
idBzkpcpDNHRh84KoSxR+hCwFjZEKqG72OdwwMEuDQQ14V6MSUFoj0OTCfYBAWJF
KKYSn+GccciW0VwPzqXMNYDALxv6J3vhdDeOBskGwP4XCGdPu6VX5SBlFF2opS70
x7wIyX5Trf2w36VOihV2klVNf8QovaqpNzGpL73+3TjdwJV/zfuDRzTPrbRQdpj9
nQRFpEalCmqp7XUN1DxQFZ+yR9XAfw==
=OhCk
-----END PGP SIGNATURE-----

--=-BrzURT1nntfCQobYCsCl--