Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Nov 2019 21:43:26 +0000
To:     Eric Biggers <ebiggers@kernel.org>
From:   Jordan Glover <Golden_Miller83@protonmail.ch>
Cc:     "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Ard Biesheuvel <ardb@kernel.org>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Samuel Neves <sneves@dei.uc.pt>, Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Martin Willi <martin@strongswan.org>,
        Rene van Dorst <opensource@vdorst.com>,
        David Sterba <dsterba@suse.com>
Reply-To: Jordan Glover <Golden_Miller83@protonmail.ch>
Subject: Re: [PATCH v5 00/34] crypto: crypto API library interfaces for WireGuard
Message-ID: <lrGGVxMWv6iZgJdHE034NrDe1vALt5cBUqfdR_sVoWBeyljevKyV-OuhYsVDLdRYd0KQix_oxneCkXLgZiqfgiYzrhnuUlS8_FOYFuoTY2I=@protonmail.ch>
In-Reply-To: <20191119162311.GA819@sol.localdomain>
References: <20191108122240.28479-1-ardb@kernel.org>
 <20191115060727.eng4657ym6obl4di@gondor.apana.org.au>
 <CAHmME9oOfhv6RN00m1c6c5qELC5dzFKS=mgDBQ-stVEWu00p_A@mail.gmail.com>
 <20191115090921.jn45akou3cw4flps@gondor.apana.org.au>
 <CAHmME9rxGp439vNYECm85bgibkVyrN7Qc+5v3r8QBmBXPZM=Dg@mail.gmail.com>
 <CAKv+Gu96xbhS+yHbEjx6dD-rOcB8QYp-Gnnc3WMWfJ9KVbJzcg@mail.gmail.com>
 <CAHmME9qRwA6yjwzoy=awWdyz40Lozf01XY2xxzYLE+G8bKsMzA@mail.gmail.com>
 <20191119162311.GA819@sol.localdomain>
Feedback-ID: QEdvdaLhFJaqnofhWA-dldGwsuoeDdDw7vz0UPs8r8sanA3bIt8zJdf4aDqYKSy4gJuZ0WvFYJtvq21y6ge_uQ==:Ext:ProtonMail
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Tuesday, November 19, 2019 4:23 PM, Eric Biggers <ebiggers@kernel.org> w=
rote:

> On Tue, Nov 19, 2019 at 04:44:11PM +0100, Jason A. Donenfeld wrote:
>
> > > So for future changes, could we please include performance numbers
> > > based on realistic workloads?
> >
> > Yea I share your concerns here. From preliminary results, I think the
> > Poly1305 code will be globally better, and I don't think we'll need an
> > abundance of discussion about it.
> > The ChaCha case is more interesting. I'll submit this with lots of
> > packet-sized microbenchmarks, as well as on-the-wire WireGuard
> > testing. Eric - I'm guessing you don't care too much about Adamantium
> > performance on x86 where people are probably better off with AES-XTS,
> > right? Are there other specific real world cases we care about? IPsec
> > is another one, but those concerns, packet-size wise, are more or less
> > the same as for WireGuard. But anyway, we can cross this bridge when
> > we come to it.
>
> I'd like for Adiantum to continue to be accelerated on x86, but it doesn'=
t have
> to squeeze out all performance possible on x86, given that hardware AES s=
upport
> is available there so most people will use that instead. So if e.g. the C=
haCha
> implementation is still AVX2 accelerated, but it's primarily optimized fo=
r
> networking packets rather than disk encryption, that would probably be fi=
ne.
>
> -   Eric

I'm interested in using Adamantium on x86 and I hope that you folks won't c=
ripple it :(

Jordan