Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Gary Hook <gary.hook@amd.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 07/12] crypto: caam - refactor caam_jr_enqueue
Thread-Topic: [PATCH 07/12] crypto: caam - refactor caam_jr_enqueue
Thread-Index: AQHVnZa0sS6CFfezokOAnr5a2apfuA==
Date:   Wed, 20 Nov 2019 06:48:46 +0000
Message-ID: <VI1PR0402MB3485EAC0D46F50CCF68AC891984F0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1574029845-22796-1-git-send-email-iuliana.prodan@nxp.com>
 <1574029845-22796-8-git-send-email-iuliana.prodan@nxp.com>
 <VI1PR0402MB34853893505F95195F4C125B984C0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
 <VI1PR04MB44452654BA9716CA43992AA68C4C0@VI1PR04MB4445.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bfa70ebc-be06-48c9-9fc4-08d76d85b133
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2019 06:48:46.6013
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Smik4Jj11py1morsMbIkxmcmB5uqTCz0HZbXIjiJVblh31ekj6S1aH20CRdzlUAUeK+yo7cV98ZaHFqQvsJW7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2718
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 11/20/2019 12:49 AM, Iuliana Prodan wrote:=0A=
> On 11/19/2019 7:55 PM, Horia Geanta wrote:=0A=
>> On 11/18/2019 12:31 AM, Iuliana Prodan wrote:=0A=
>>> diff --git a/drivers/crypto/caam/caamhash.c b/drivers/crypto/caam/caamh=
ash.c=0A=
>>> index baf4ab1..d9de3dc 100644=0A=
>>> --- a/drivers/crypto/caam/caamhash.c=0A=
>>> +++ b/drivers/crypto/caam/caamhash.c=0A=
>> [...]=0A=
>>> @@ -933,11 +943,13 @@ static int ahash_final_ctx(struct ahash_request *=
req)=0A=
>>>   			     DUMP_PREFIX_ADDRESS, 16, 4, desc, desc_bytes(desc),=0A=
>>>   			     1);=0A=
>>>   =0A=
>>> -	ret =3D caam_jr_enqueue(jrdev, desc, ahash_done_ctx_src, req);=0A=
>>> +	jrentry =3D &edesc->jrentry;=0A=
>>> +=0A=
>>> +	ret =3D caam_jr_enqueue(jrdev, desc, ahash_done_ctx_src, jrentry);=0A=
>>>   	if (ret =3D=3D -EINPROGRESS)=0A=
>>>   		return ret;=0A=
>>>   =0A=
>>> - unmap_ctx:=0A=
>>> +unmap_ctx:=0A=
>> That's correct, however whitespace fixing should be done separately.=0A=
>>=0A=
> Should I make a separate patch for these two whitespaces?=0A=
> =0A=
Whitespace fixes should be moved out of this patch set.=0A=
In general, patches handling this go through the whole file / driver.=0A=
=0A=
Horia=0A=