Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Gary Hook <gary.hook@amd.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 10/12] crypto: caam - add crypto_engine support for AEAD
 algorithms
Thread-Topic: [PATCH 10/12] crypto: caam - add crypto_engine support for AEAD
 algorithms
Thread-Index: AQHVnZa1FyZOwAzxGE6ZWqnis9ksHA==
Date:   Thu, 21 Nov 2019 16:46:02 +0000
Message-ID: <VI1PR0402MB3485587572B8720F372F4ED5984E0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1574029845-22796-1-git-send-email-iuliana.prodan@nxp.com>
 <1574029845-22796-11-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bbc3181a-6384-43b4-79b6-08d76ea24b94
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2019 16:46:02.7064
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EK+ElHOIXMwqF4qLesKC2CyDxMYveuxrv2h8JCnUK1kk2QC9GFlfUZJs6ZwhrWhnL3HfWVffecmdTNKU5jtX5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2944
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 11/18/2019 12:31 AM, Iuliana Prodan wrote:=0A=
> @@ -1465,7 +1484,6 @@ static inline int aead_crypt(struct aead_request *r=
eq, bool encrypt)=0A=
>  	struct aead_edesc *edesc;=0A=
>  	struct crypto_aead *aead =3D crypto_aead_reqtfm(req);=0A=
>  	struct caam_ctx *ctx =3D crypto_aead_ctx(aead);=0A=
> -	struct caam_jr_request_entry *jrentry;=0A=
>  	struct device *jrdev =3D ctx->jrdev;=0A=
>  	bool all_contig;=0A=
>  	u32 *desc;=0A=
> @@ -1479,16 +1497,14 @@ static inline int aead_crypt(struct aead_request =
*req, bool encrypt)=0A=
>  =0A=
>  	/* Create and submit job descriptor */=0A=
>  	init_authenc_job(req, edesc, all_contig, encrypt);=0A=
> +	desc =3D edesc->hw_desc;=0A=
>  =0A=
This change is unrelated.=0A=
=0A=
>  	print_hex_dump_debug("aead jobdesc@"__stringify(__LINE__)": ",=0A=
> -			     DUMP_PREFIX_ADDRESS, 16, 4, edesc->hw_desc,=0A=
> -			     desc_bytes(edesc->hw_desc), 1);=0A=
> -=0A=
> -	desc =3D edesc->hw_desc;=0A=
> -	jrentry =3D &edesc->jrentry;=0A=
> +			     DUMP_PREFIX_ADDRESS, 16, 4, desc,=0A=
> +			     desc_bytes(desc), 1);=0A=
>  =0A=
[...]=0A=
>  static inline int gcm_crypt(struct aead_request *req, bool encrypt)=0A=
>  {=0A=
>  	struct aead_edesc *edesc;=0A=
>  	struct crypto_aead *aead =3D crypto_aead_reqtfm(req);=0A=
>  	struct caam_ctx *ctx =3D crypto_aead_ctx(aead);=0A=
>  	struct device *jrdev =3D ctx->jrdev;=0A=
> -	struct caam_jr_request_entry *jrentry;=0A=
>  	bool all_contig;=0A=
>  	u32 *desc;=0A=
>  	int ret =3D 0;=0A=
> @@ -1525,16 +1565,14 @@ static inline int gcm_crypt(struct aead_request *=
req, bool encrypt)=0A=
>  =0A=
>  	/* Create and submit job descriptor */=0A=
>  	init_gcm_job(req, edesc, all_contig, encrypt);=0A=
> +	desc =3D edesc->hw_desc;=0A=
>  =0A=
Same here.=0A=
=0A=
>  	print_hex_dump_debug("aead jobdesc@"__stringify(__LINE__)": ",=0A=
> -			     DUMP_PREFIX_ADDRESS, 16, 4, edesc->hw_desc,=0A=
> -			     desc_bytes(edesc->hw_desc), 1);=0A=
> -=0A=
> -	desc =3D edesc->hw_desc;=0A=
> -	jrentry =3D &edesc->jrentry;=0A=
> +			     DUMP_PREFIX_ADDRESS, 16, 4, desc,=0A=
> +			     desc_bytes(desc), 1);=0A=
>  =0A=
=0A=
Horia=0A=