Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Gary Hook <gary.hook@amd.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 11/12] crypto: caam - add crypto_engine support for RSA
 algorithms
Thread-Topic: [PATCH 11/12] crypto: caam - add crypto_engine support for RSA
 algorithms
Thread-Index: AQHVnZa1Je0BlUBIrE+TMPovQJFAQg==
Date:   Thu, 21 Nov 2019 16:53:54 +0000
Message-ID: <VI1PR0402MB348579F11E5BF69DBACF756A984E0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1574029845-22796-1-git-send-email-iuliana.prodan@nxp.com>
 <1574029845-22796-12-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f2ac4fb-913d-4e17-2dad-08d76ea364d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2019 16:53:54.5864
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VXKMziiVZH0busgOc1E51NVTrmtfc0UWWJW5eZDpxdgpWcjWsawDTvIxFQ6T1aY1MasoLX+iVWcVmFpIdDJ63A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2782
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 11/18/2019 12:31 AM, Iuliana Prodan wrote:=0A=
> @@ -311,14 +329,16 @@ static struct rsa_edesc *rsa_edesc_alloc(struct akc=
ipher_request *req,=0A=
>  	edesc->src_nents =3D src_nents;=0A=
>  	edesc->dst_nents =3D dst_nents;=0A=
>  =0A=
> +	edesc->jrentry.base =3D &req->base;=0A=
> +=0A=
> +	req_ctx->edesc =3D edesc;=0A=
> +=0A=
>  	if (!sec4_sg_bytes)=0A=
>  		return edesc;=0A=
>  =0A=
>  	edesc->mapped_src_nents =3D mapped_src_nents;=0A=
>  	edesc->mapped_dst_nents =3D mapped_dst_nents;=0A=
>  =0A=
> -	edesc->jrentry.base =3D &req->base;=0A=
> -=0A=
This is a bug fix - edesc->jrentry.base must be set earlier,=0A=
before having the chance to return from the function (in case no S/G table=
=0A=
needs to be generated).=0A=
=0A=
It should be squashed into=0A=
[PATCH 07/12] crypto: caam - refactor caam_jr_enqueue=0A=
=0A=
Horia=0A=