Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Gary Hook <gary.hook@amd.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 12/12] crypto: caam - add crypto_engine support for HASH
 algorithms
Thread-Topic: [PATCH 12/12] crypto: caam - add crypto_engine support for HASH
 algorithms
Thread-Index: AQHVnZa1YAvOB9zlFEuQgR2AeTqLIg==
Date:   Thu, 21 Nov 2019 17:06:59 +0000
Message-ID: <VI1PR0402MB3485A57B6A13B5571DF93B53984E0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1574029845-22796-1-git-send-email-iuliana.prodan@nxp.com>
 <1574029845-22796-13-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: be9f06fa-7ae2-4334-12d5-08d76ea538b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2019 17:06:59.4920
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 74jubjwUDfs5UJglRVDmEwgW05zQRnXKT3UdeHfcbUUsxGTDhBuLFVpJCRtjda5Khqj1WEW1nVbee8jZeQAo0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3374
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 11/18/2019 12:31 AM, Iuliana Prodan wrote:=0A=
> @@ -1150,20 +1201,19 @@ static int ahash_final_no_ctx(struct ahash_reques=
t *req)=0A=
>  			     DUMP_PREFIX_ADDRESS, 16, 4, desc, desc_bytes(desc),=0A=
>  			     1);=0A=
>  =0A=
> -	jrentry =3D &edesc->jrentry;=0A=
> +	state->ahash_op_done =3D ahash_done;=0A=
>  =0A=
> -	ret =3D caam_jr_enqueue(jrdev, desc, ahash_done, jrentry);=0A=
> -	if (ret !=3D -EINPROGRESS) {=0A=
> +	ret =3D caam_jr_enqueue(jrdev, desc, ahash_done, &edesc->jrentry);=0A=
> +	if ((ret !=3D -EINPROGRESS) && (ret !=3D -EBUSY)) {=0A=
>  		ahash_unmap_ctx(jrdev, edesc, req, digestsize, DMA_FROM_DEVICE);=0A=
>  		kfree(edesc);=0A=
>  	}=0A=
>  =0A=
>  	return ret;=0A=
> - unmap:=0A=
> +unmap:=0A=
>  	ahash_unmap(jrdev, edesc, req, digestsize);=0A=
>  	kfree(edesc);=0A=
>  	return -ENOMEM;=0A=
> -=0A=
>  }=0A=
Unrelated whitespace changes.=0A=
=0A=
> @@ -1294,7 +1344,7 @@ static int ahash_update_no_ctx(struct ahash_request=
 *req)=0A=
>  			     1);=0A=
>  =0A=
>  	return ret;=0A=
> - unmap_ctx:=0A=
> +unmap_ctx:=0A=
Same here.=0A=
=0A=
> @@ -1509,6 +1558,7 @@ static int ahash_init(struct ahash_request *req)=0A=
>  	state->update =3D ahash_update_first;=0A=
>  	state->finup =3D ahash_finup_first;=0A=
>  	state->final =3D ahash_final_no_ctx;=0A=
> +	state->ahash_op_done =3D ahash_done;=0A=
>  =0A=
Is this initialization really needed?=0A=
=0A=
Horia=0A=
=0A=