Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Nov 2019 12:02:18 -0800 (PST)
Message-Id: <20191121.120218.822468406949238769.davem@davemloft.net>
To:     rahul.lakkireddy@chelsio.com
Cc:     netdev@vger.kernel.org, linux-crypto@vger.kernel.org,
        herbert@gondor.apana.org.au, nirranjan@chelsio.com,
        atul.gupta@chelsio.com, vishal@chelsio.com, dt@chelsio.com
Subject: Re: [PATCH net-next 2/3] cxgb4: add UDP segmentation offload
 support
From:   David Miller <davem@davemloft.net>
In-Reply-To: <2ddeefa22022f3949901c96892b8bf56a369f724.1574347161.git.rahul.lakkireddy@chelsio.com>
References: <cover.1574347161.git.rahul.lakkireddy@chelsio.com>
        <cover.1574347161.git.rahul.lakkireddy@chelsio.com>
        <2ddeefa22022f3949901c96892b8bf56a369f724.1574347161.git.rahul.lakkireddy@chelsio.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Date: Thu, 21 Nov 2019 20:50:48 +0530

> @@ -1345,6 +1355,25 @@ static inline int cxgb4_validate_skb(struct sk_buff *skb,
>  	return 0;
>  }
>  
> +static inline void *write_eo_udp_wr(struct sk_buff *skb,
> +				    struct fw_eth_tx_eo_wr *wr, u32 hdr_len)
> +{

Do not use inline in foo.c files, let the compiler decide.

I know this source file is already a rotting mess of inline function
directives, but let's not add more.