Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Horia Geanta <horia.geanta@nxp.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Gary Hook <gary.hook@amd.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 01/12] crypto: add helper function for akcipher_request
Thread-Topic: [PATCH 01/12] crypto: add helper function for akcipher_request
Thread-Index: AQHVnZazFVUFTJ6/6kmX8sqUgv70rQ==
Date:   Fri, 22 Nov 2019 10:29:01 +0000
Message-ID: <VI1PR04MB44458463C3FFBF7C2D99B4DE8C490@VI1PR04MB4445.eurprd04.prod.outlook.com>
References: <1574029845-22796-1-git-send-email-iuliana.prodan@nxp.com>
 <1574029845-22796-2-git-send-email-iuliana.prodan@nxp.com>
 <20191122090819.mv3txjoxmiy4flv2@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a9d1f8d6-cc4d-452d-9e53-08d76f36cae7
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2019 10:29:01.8040
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ibp5QB+JL3S5etBipIT7txDa0VcteGoLNkI7snuSKLE5SSQ5LAafWtAfzInDIBU5e7T1d69hYplUybVY50bpmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6144
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 11/22/2019 11:08 AM, Herbert Xu wrote:=0A=
> On Mon, Nov 18, 2019 at 12:30:34AM +0200, Iuliana Prodan wrote:=0A=
>>=0A=
>> diff --git a/include/crypto/akcipher.h b/include/crypto/akcipher.h=0A=
>> index 6924b09..4365edd 100644=0A=
>> --- a/include/crypto/akcipher.h=0A=
>> +++ b/include/crypto/akcipher.h=0A=
>> @@ -170,6 +170,12 @@ static inline struct crypto_akcipher *crypto_akciph=
er_reqtfm(=0A=
>>   	return __crypto_akcipher_tfm(req->base.tfm);=0A=
>>   }=0A=
>>   =0A=
>> +static inline struct akcipher_request *akcipher_request_cast(=0A=
>> +	struct crypto_async_request *req)=0A=
>> +{=0A=
>> +	return container_of(req, struct akcipher_request, base);=0A=
>> +}=0A=
> =0A=
> This should go into include/crypto/internal/akcipher.h as it's=0A=
> only used by implementors.=0A=
> =0A=
> But having reviewed the subsequent patches I think we shouldn't=0A=
> have this function at all.=0A=
> =0A=
=0A=
Why can't we use this? There are similar functions for =0A=
skcipher/aead/ahash and they are all in include/crypto.=0A=
=0A=
Thanks,=0A=
Iulia=0A=