Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp41629pja; Fri, 22 Nov 2019 03:12:08 -0800 (PST) X-Google-Smtp-Source: APXvYqzXfjJQx/G+mVb4yfKCPGkik6tiSX3/MJYEoYg5RYwweFvAJD9IwL0GQ6iwkD2L3PAByXEE X-Received: by 2002:aa7:c74e:: with SMTP id c14mr359755eds.260.1574421128124; Fri, 22 Nov 2019 03:12:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574421128; cv=none; d=google.com; s=arc-20160816; b=lcf6zSF+mQQ8QKtt08AcDqHUuz+t7pbN9to96tFavy/74nDjeTZYmxjhjU5JHA4TUL ceVVLxByjZTS5VSNVlBP1sea3pikEUXu9R5YDavjYOfMdwDm2FbHisAX3NACFuN8kldX EBVVd24+hxqsBcXkSkcm/ZSlor8bAQl8hP5rRGWs0zeWUJipEr4KHMFpCTu3I7CJGEcN m2c1cfp/IvqpERY7j051jn5kl1hcL74yPiyLokEre4FLvvpApeNwYWTfsiBlBqfeSCne YITFXuWAPTIi57VgOlJWOOsqPUQok5S/y8dcIWVQKS5Z0JdirQi7gSPRaZgGEe2WDGef a1Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:message-id:subject:cc:to:from:date; bh=15DKzAwoCQ9UP6lnReegKIBkplDD47/yUTLUuTTCMuU=; b=CZx7KlXGHq1xBtE4dPDw1dIS5Pt6ezAT+VfV1NGwLVK16IefzF+mIUc5LxOwEKSqHi nv51JS/LYV1FMgLJeoCSOqnskbPT3Q+Zowusy9CEYK2KyerzQJAAppFlT6B2sOMWYlf+ dWpfiXtQF1peDK1n1ufij0S557MTUCp5nTvRDqPN/XHde7z4ScndAaH2atZSa4hA4tPr m1Ia/1X5k21zfLJd5zVJLmchj5oy3VBpf/kGtD0bhT5KMcJCpmAxAuxIm9/scRpN0DBw dbf/7IGkBLyRuP4h4qHrG1UH6up3QYD1y3GaFKz/YTe4P+vs2Eq088RWxNUXUgEsj+Gj /0ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b49si1106358eda.312.2019.11.22.03.11.43; Fri, 22 Nov 2019 03:12:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731293AbfKVLCY (ORCPT + 99 others); Fri, 22 Nov 2019 06:02:24 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:53202 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730223AbfKVLCU (ORCPT ); Fri, 22 Nov 2019 06:02:20 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iY6hf-0004O4-1a; Fri, 22 Nov 2019 19:02:19 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iY6hc-0002cg-FO; Fri, 22 Nov 2019 19:02:16 +0800 Date: Fri, 22 Nov 2019 19:02:16 +0800 From: Herbert Xu To: David Sterba Cc: linux-crypto@vger.kernel.org, ebiggers@kernel.org, dsterba@suse.com Subject: Re: [PATCH v2 0/7] BLAKE2b cleanups Message-ID: <20191122110216.4quahkxnkd3w67dg@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Newsgroups: apana.lists.os.linux.cryptoapi Organization: Core User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org David Sterba wrote: > Hi, > > the patchset implements cleanups suggested by Eric in > https://lore.kernel.org/linux-crypto/20191025051550.GA103313@sol.localdomain/ > > The diff is almost the same, split into pieces with some additional > comments where it would help understand the simplifications. This is > based on v7 of the BLAKE2b patchset. > > The self-tests have been run for each patch on x86_64. > > V2: > - rename digest_setkey to blake2b_setkey, this is in patch 7 that also > does a rename, to avoid a too-trivial separate patch > - minor withespace fix in patch 6 > > David Sterba (7): > crypto: blake2b: merge _final implementation to callback > crypto: blake2b: merge blake2 init to api callback > crypto: blake2b: simplify key init > crypto: blake2b: delete unused structs or members > crypto: blake2b: open code set last block helper > crypto: blake2b: merge _update to api callback > crypto: blake2b: rename tfm context and _setkey callback > > crypto/blake2b_generic.c | 279 ++++++++++++--------------------------- > 1 file changed, 82 insertions(+), 197 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt