Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp70394ybc; Fri, 22 Nov 2019 16:20:34 -0800 (PST) X-Google-Smtp-Source: APXvYqyHZ15Od8BdhcBLiT/OZthlumRcoABnu9NJwbT2olKYDK4E3sYa2FvCJyLXNbH1Rj9NGcXa X-Received: by 2002:a50:ac81:: with SMTP id x1mr4583803edc.200.1574468434769; Fri, 22 Nov 2019 16:20:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574468434; cv=none; d=google.com; s=arc-20160816; b=uLp8RLpQgBC7FxZoJhPayuaZDLVQQjdRngh5tU/ONZK5R71n3gQtETUU5KjDmyi1RD 5HNos8kc/50Mx5GvhIXmMGbt3rNdOg0fGCb87gTn/lp1kwN8FzUHKsovTxMGlU6HxPPf QJ12OLgKyfIihHY04AVDj0Grcd9qqD2gi5F9wFaG7i0xdfeGnRpFZzq3Q8BszZxpTHQB TYm4MZE3dXPuC6emr0CNaMpq6OxyMYcoqEfyDEg4L2jumLm0CEl1OQfde/A9AsKOtkyg oz6Kw9aNAfvNLZFkCNQ2Do7wq4Q2w0Ee3gZ9HPx6751jJzIRzqnP2CezWYnVrUYE1jbz PIZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=cCKUrCts2+t8rP0ScV3w0/Tj1cDEwboZDIJtSXZbwS8=; b=NNnJ+7yibaTcG/0N1X7fnz/pIhM8E14aR3X9TMmNqQNaHhwrvhDemcFBs9hFV8zG6P qmOckLGmjMp1EQnzJjJT19oCyS4cOUcCjPR91h+HPD/Bw0esN8IjeLqpsA0eQnt62fz/ CWdUbVQzA1Rsdzy2XzpCQK/eA71ISfOb5d5puV+Z/UoUgd8sNF/B1jn0GoY4H3LlXZ+6 av3/fftLAjWEx/axkphXNrOmpy9Pcpkq5aL9ZGVyaiFA90+DxnH7EHPQtoLJHYpqWMve EFg7gyt8CqO0ls4n8xg+89BiIfF5WEuaLYeZUC5ecS1onkqJdX2u/Lb37sFmOGa4l9/o jgfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=CQQTqlgm; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g22si2534743edw.338.2019.11.22.16.20.03; Fri, 22 Nov 2019 16:20:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=CQQTqlgm; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726686AbfKWAT4 (ORCPT + 99 others); Fri, 22 Nov 2019 19:19:56 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:43398 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbfKWAT4 (ORCPT ); Fri, 22 Nov 2019 19:19:56 -0500 Received: by mail-lf1-f65.google.com with SMTP id l14so6797724lfh.10 for ; Fri, 22 Nov 2019 16:19:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=cCKUrCts2+t8rP0ScV3w0/Tj1cDEwboZDIJtSXZbwS8=; b=CQQTqlgmc9AoFm+WbiVEsoL41/6vqIC8qlytBOiVKqcRaJEpqoXoSrUx9732545WRK l0AhBUzKceVPXDCzFVDPLiotmWd6kTR/BfvUmJLcxHpp8pS6bgpuqiTIZ2EzY1NErkR+ vI3feiJQbfeNzMR1UGjIY9KdmpD4x0vdBC1qjeEOWeVJKTWdZxsPVSQfn85sGcKwAblA K07cg6F69Z6xS6ePTAJdnCYzHF4QP56BWV6btedeMRMzR8BCQlHC+sNbGct+lur8tMX1 YsVNjBMZAuLHvl0XxOlHC/Z0y/BtRegNHiAPnK8KksUMxB2L7BU7fFtXhnumcOlQsh8H ssIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=cCKUrCts2+t8rP0ScV3w0/Tj1cDEwboZDIJtSXZbwS8=; b=a774Z2rSVNYcdh1nBFH2aywHqQb2mqNnoYaot8bt42461VxgpP5Iuv/LK6fXAd3JKI B9TsLBehXqLzJw0ofROc8XK5EvfW4FP9TlUtFSZthtqMtcFVFMWCmjBPkXCkqanD1vbG ABbJBYiHe1Snffcdg/JsryE+F8++9TrWkHBGR47jpTNKEkMFaZXQ9Nbj8bL2aruA6nTu xJ9gCdGHlA9JtJkfzSSJh1fcKwfK2Z9I0tuXuU2qEnyf8Z6+LOQ98mRgSFl/mDQDPGIX X87wKeJJ/SpsWV2/bWwlA1l5bB5n5UiJEyDbQpOvEIQqypRR6JuNDCMORjoZ+vUIroD4 Fj0w== X-Gm-Message-State: APjAAAWVUTO2ov1wy7EdmbYBNa+jn0+SHaTDfmZb3PcxFUe1W2KtPz56 FbeqxuJ0yJGq3U2onBXh9R8IVpck3TM= X-Received: by 2002:a19:756:: with SMTP id 83mr11599176lfh.173.1574468394114; Fri, 22 Nov 2019 16:19:54 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id x23sm3825648lfe.8.2019.11.22.16.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 16:19:53 -0800 (PST) Date: Fri, 22 Nov 2019 16:19:45 -0800 From: Jakub Kicinski To: Rahul Lakkireddy Cc: netdev@vger.kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net, herbert@gondor.apana.org.au, nirranjan@chelsio.com, atul.gupta@chelsio.com, vishal@chelsio.com, dt@chelsio.com Subject: Re: [PATCH net-next v2 1/3] cxgb4/chcr: update SGL DMA unmap for USO Message-ID: <20191122161945.1086e58c@cakuba.netronome.com> In-Reply-To: <20191122160629.3800b5cc@cakuba.netronome.com> References: <6cf3a3928ff2ee84cca34bfcb61d3f7fcb4c4cac.1574383652.git.rahul.lakkireddy@chelsio.com> <20191122160629.3800b5cc@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, 22 Nov 2019 16:06:29 -0800, Jakub Kicinski wrote: > > -struct tx_sw_desc; > > +struct ulptx_sgl; > > From this patch alone the forward declaration of struct ulptx_sgl; > appears unnecessary or a left over from some previous version of the > code? Okay, taking that back, looks like compiler treats use of struct type in another struct as a forward declaration. Interesting.