Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] crypto: ccp: set max RSA modulus size for v3 platform
 devices as well
To:     Ard Biesheuvel <ardb@kernel.org>, linux-crypto@vger.kernel.org
Cc:     herbert@gondor.apana.org.au
References: <20191127120136.105325-1-ardb@kernel.org>
From:   "Hook, Gary" <gary.hook@amd.com>
Message-ID: <dcb66129-1cb7-cc67-acf6-07abb4047794@amd.com>
Date:   Wed, 27 Nov 2019 15:04:56 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
In-Reply-To: <20191127120136.105325-1-ardb@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: 41a174d3-2add-4aeb-6c22-08d7737d766d
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2019 21:04:59.4611
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e1+zozXzy6n1GyIkXYZvMr2fEwI3kzBOUb/IshNG2Gadp6QrX7hbQp58jv+WRNrc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2390
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 11/27/2019 6:01 AM, Ard Biesheuvel wrote:
> AMD Seattle incorporates a non-PCI version of the v3 CCP crypto
> accelerator, and this version was left behind when the maximum
> RSA modulus size was parameterized in order to support v5 hardware
> which supports larger moduli than v3 hardware does. Due to this
> oversight, RSA acceleration no longer works at all on these systems.
>
> Fix this by setting the .rsamax property to the appropriate value
> for v3 platform hardware.
>
> Fixes: e28c190db66830c0 ("csrypto: ccp - Expand RSA support for a v5 ccp")
> Cc: Gary R Hook <gary.hook@amd.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

Acked-by: Gary R Hook <gary.hook@amd.com>

> ---
>   drivers/crypto/ccp/ccp-dev-v3.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/ccp-dev-v3.c b/drivers/crypto/ccp/ccp-dev-v3.c
> index 0186b3df4c87..0d5576f6ad21 100644
> --- a/drivers/crypto/ccp/ccp-dev-v3.c
> +++ b/drivers/crypto/ccp/ccp-dev-v3.c
> @@ -586,6 +586,7 @@ const struct ccp_vdata ccpv3_platform = {
>   	.setup = NULL,
>   	.perform = &ccp3_actions,
>   	.offset = 0,
> +	.rsamax = CCP_RSA_MAX_WIDTH,
>   };
>   
>   const struct ccp_vdata ccpv3 = {