Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191207041937.97925-1-ebiggers@kernel.org>
In-Reply-To: <20191207041937.97925-1-ebiggers@kernel.org>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Sat, 7 Dec 2019 10:15:57 +0000
Message-ID: <CAKv+Gu8za_CcBdeeZhXC4ARZ6FakUbRrNKb6J8dycgqrc59Omw@mail.gmail.com>
Subject: Re: [PATCH] crypto: doc - remove references to ARC4
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Sat, 7 Dec 2019 at 04:20, Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> arc4 is no longer considered secure, so it shouldn't be used, even as
> just an example.  Mention serpent and chacha20 instead.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  Documentation/crypto/devel-algos.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/crypto/devel-algos.rst b/Documentation/crypto/devel-algos.rst
> index f9d288015acc..fb6b7979a1de 100644
> --- a/Documentation/crypto/devel-algos.rst
> +++ b/Documentation/crypto/devel-algos.rst
> @@ -57,7 +57,7 @@ follows:
>  Single-Block Symmetric Ciphers [CIPHER]
>  ---------------------------------------
>
> -Example of transformations: aes, arc4, ...
> +Example of transformations: aes, serpent, ...
>
>  This section describes the simplest of all transformation
>  implementations, that being the CIPHER type used for symmetric ciphers.
> @@ -108,7 +108,7 @@ is also valid:
>  Multi-Block Ciphers
>  -------------------
>
> -Example of transformations: cbc(aes), ecb(arc4), ...
> +Example of transformations: cbc(aes), chacha20, ...
>
>  This section describes the multi-block cipher transformation
>  implementations. The multi-block ciphers are used for transformations
> --
> 2.24.0
>