Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5408851ybl; Tue, 10 Dec 2019 05:39:48 -0800 (PST) X-Google-Smtp-Source: APXvYqwcFhYh/qqOqyeVZ6iT/1jIUubDb8Zs3DmQwAJjX3SnHpQC4puCBiZv6aBCYpLW0bvsnMpr X-Received: by 2002:aca:815:: with SMTP id 21mr4107820oii.52.1575985188245; Tue, 10 Dec 2019 05:39:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575985188; cv=none; d=google.com; s=arc-20160816; b=ia55gOm0YY7c/6w0m02TZ8Qg+F1X4d9U4KBU1f6UEJ5QLF+Pv2/vzYGVQaj0niIIFh 0CjcubgtG3qyBdwitNo7+Hm+Dt+7gyX26zfFmTsiIgu/qhG9tUV6hfRPxDXE7uzqwjcn LL5e4j7Ti7BS0KNgPaHI1K1v/tA+VIoW2tjOIO/xzuxGLtLyziLRUDk5TNsudh3e0vTn uydg7F+Lf6JZrTjpMIjdLIwVoO0gWykFD8Qw+aItvBWQRHDaZqcDOiA8QrSnIB6LwdYs uwk7M3vS05THvJxUEwhXEm2/gUqNHbBDiLI54Tv/KJSP3vJBT0F+ghGLwF4Qoghu7DR/ p7hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=f2S8o+kzvhrem0ki9eIRw3RKzaBnilklOFQkcyr7dyQ=; b=TfSxFgxIN+xUzoJeCctPQZyzn+XhbuWiF0meuHRCBHbPIcVxxkAcBipQPYV/BhN4+k HqetSlzhONjb3x/yEa6eFukMv4xpcWwxsYy6X0lNk049sFt8AeGAwhJZOZFyBlyjFBL+ fhfAHs+VTNrseJyOghJ0LyVvjIQKLuvIc5AxZ33vtCXJMcHOMxSX0PT7rfu9q8es/ZS9 etfkeYV6jBkT0Cbqc2y0h2ZzaLJFnu1B+lbX9y8C1VfV2gmkceOYWK2yqnwri9544aSb IANu+R16T4ProV+f/ck+pDOnreyO1a5L1PNosvpI09xkt6fEbJ66DxTuC2XpHqC+HJdG GQOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t189si1779566oie.13.2019.12.10.05.39.29; Tue, 10 Dec 2019 05:39:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbfLJNj2 (ORCPT + 99 others); Tue, 10 Dec 2019 08:39:28 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:56340 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727131AbfLJNj2 (ORCPT ); Tue, 10 Dec 2019 08:39:28 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iefja-0004X1-JE; Tue, 10 Dec 2019 21:39:26 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iefjY-00044n-1z; Tue, 10 Dec 2019 21:39:24 +0800 Date: Tue, 10 Dec 2019 21:39:24 +0800 From: Herbert Xu To: Yunfeng Ye Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.or, "hushiyuan@huawei.com" , "linfeilong@huawei.com" Subject: Re: [PATCH] crypto: user - use macro CRYPTO_MSG_INDEX() to instead of index calculation Message-ID: <20191210133923.aab65usf4xyqd3wv@gondor.apana.org.au> References: <6306e685-51fa-1a04-e9d9-07d4c80b5400@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6306e685-51fa-1a04-e9d9-07d4c80b5400@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Dec 10, 2019 at 07:07:36PM +0800, Yunfeng Ye wrote: > There are multiple places using CRYPTO_MSG_BASE to calculate the index, > so use macro CRYPTO_MSG_INDEX() instead for better readability. > > Signed-off-by: Yunfeng Ye I don't think your patch makes it any more readable. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt