Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 11 Dec 2019 17:43:34 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-crypto@vger.kernel.org
Subject: Re: [PATCH 0/7] crypto: more self-test improvements
Message-ID: <20191211094334.y5ykf4supval6feu@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191201215330.171990-1-ebiggers@kernel.org>
Organization: Core
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Eric Biggers <ebiggers@kernel.org> wrote:
> This series makes some more improvements to the crypto self-tests, the
> largest of which is making the AEAD fuzz tests test inauthentic inputs,
> i.e. cases where decryption is expected to fail due to the (ciphertext,
> AAD) pair not being the correct result of an encryption with the key.
> 
> It also updates the self-tests to test passing misaligned buffers to the
> various setkey() functions, and to check that skciphers have the same
> min_keysize as the corresponding generic implementation.
> 
> I haven't seen any test failures from this on x86_64, arm64, or arm32.
> But as usual I haven't tested drivers for crypto accelerators.
> 
> For this series to apply this cleanly, my other series
> "crypto: skcipher - simplifications due to {,a}blkcipher removal"
> needs to be applied first, due to a conflict in skcipher.h.
> 
> This can also be retrieved from git at 
> https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
> tag "crypto-self-tests_2019-12-01".
> 
> Eric Biggers (7):
>  crypto: aead - move crypto_aead_maxauthsize() to <crypto/aead.h>
>  crypto: skcipher - add crypto_skcipher_min_keysize()
>  crypto: testmgr - don't try to decrypt uninitialized buffers
>  crypto: testmgr - check skcipher min_keysize
>  crypto: testmgr - test setting misaligned keys
>  crypto: testmgr - create struct aead_extra_tests_ctx
>  crypto: testmgr - generate inauthentic AEAD test vectors
> 
> crypto/testmgr.c               | 574 +++++++++++++++++++++++++--------
> crypto/testmgr.h               |  14 +-
> include/crypto/aead.h          |  10 +
> include/crypto/internal/aead.h |  10 -
> include/crypto/skcipher.h      |   6 +
> 5 files changed, 461 insertions(+), 153 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt