Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2859784ybl; Thu, 19 Dec 2019 23:10:14 -0800 (PST) X-Google-Smtp-Source: APXvYqz/MD5iwqNFD54ZsxdWS5auJ8X0BB9gKoYFZufyn2MUnMZlcJcA0nVL+6GWtu5GEuFq0Xxx X-Received: by 2002:a9d:20e4:: with SMTP id x91mr13086936ota.335.1576825813922; Thu, 19 Dec 2019 23:10:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576825813; cv=none; d=google.com; s=arc-20160816; b=rUoQDhdf1R17l+aGfk522tajM+MUavs6qi0oqNYUrjdpHB1yjnGbfUce7YU0ZKURW7 I+N6wBRYAYpw+HdGfQ99HF+ZsBFenxq2ZpcdiXSr1fR7BaVfxqweidid3UPZevD6eSBb y9sEZff8n9+WEYKY7M5qcwii5KNsRUjkCCVuZimI2VeiguC9VlLAlPPobRkRkHJYxJx3 4eNB2myO8RYsP1st93DaZKyebYF2MBQZSEQvqSYwOdqaMCVZMp2sEkixKh6ZqPk9w9Qw MCRfEMOtA46Md4Ks2Mka8Iv5hd5uKFE1ufmr9uPsEazeqaVWUQ9FqJ6frACSyuTNeRfK 8lpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Rww2JpCxZXZflI5x/95JkTuE3FvgmHpEo5xwD4D3c5c=; b=rqCbegQPvLyunN1JYCTddRJ2M/8u/Bd6Ovg+U5Mi1vfTQWvHjta+tlTOiEHQg2KARC 3VJoBIoEZkaUidFNLJ4YMtiAVNb1RWVx4iefDWkN1+vcDPIVPLDwssZdw8/EIeZ/mWBb qA64DR5P8BWmmWWQkoR0m0eKC3jTHxyVnysu8uJX5taz0omAQN5cAl6GdUCxjVT2J1uJ tdYkJ+AAfojNaHNd4hbKhURFeb0S4llhLAQBGdFGnDOLeh8yTIKc3nVvn5xRJyB22sqw /YkgzOImEdjy8nlzUiRQ6s/ZVHbnQU2Q3CvBNsZZIMr4XSIKZI9NRyzO4672MH1UeQ1T VHrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v21si5671514otf.87.2019.12.19.23.10.03; Thu, 19 Dec 2019 23:10:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727089AbfLTHJ4 (ORCPT + 99 others); Fri, 20 Dec 2019 02:09:56 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:59040 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbfLTHJ4 (ORCPT ); Fri, 20 Dec 2019 02:09:56 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iiCQ1-0000Ar-1m; Fri, 20 Dec 2019 15:09:49 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iiCPz-0007uD-82; Fri, 20 Dec 2019 15:09:47 +0800 Date: Fri, 20 Dec 2019 15:09:47 +0800 From: Herbert Xu To: Mark Brown Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , Eric Biggers , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH] arm64: crypto: Use modern annotations for assembly functions Message-ID: <20191220070947.5me6oi2nqrinigao@gondor.apana.org.au> References: <20191213154910.32479-1-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213154910.32479-1-broonie@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Dec 13, 2019 at 03:49:10PM +0000, Mark Brown wrote: > In an effort to clarify and simplify the annotation of assembly functions > in the kernel new macros have been introduced. These replace ENTRY and > ENDPROC and also add a new annotation for static functions which previously > had no ENTRY equivalent. Update the annotations in the crypto code to the > new macros. > > There are a small number of files imported from OpenSSL where the assembly > is generated using perl programs, these are not currently annotated at all > and have not been modified. > > Signed-off-by: Mark Brown > --- > > I'm intending to do this for all the rest of the asm too, this is the > simplest directory and there's no direct interdependencies so starting > here. > > arch/arm64/crypto/aes-ce-ccm-core.S | 16 +++++------ > arch/arm64/crypto/aes-ce-core.S | 16 +++++------ > arch/arm64/crypto/aes-ce.S | 4 +-- > arch/arm64/crypto/aes-cipher-core.S | 8 +++--- > arch/arm64/crypto/aes-modes.S | 16 +++++------ > arch/arm64/crypto/aes-neon.S | 4 +-- > arch/arm64/crypto/aes-neonbs-core.S | 40 +++++++++++++-------------- > arch/arm64/crypto/chacha-neon-core.S | 16 +++++------ > arch/arm64/crypto/crct10dif-ce-core.S | 12 ++++---- > arch/arm64/crypto/ghash-ce-core.S | 8 +++--- > arch/arm64/crypto/nh-neon-core.S | 4 +-- > arch/arm64/crypto/sha1-ce-core.S | 4 +-- > arch/arm64/crypto/sha2-ce-core.S | 4 +-- > arch/arm64/crypto/sha3-ce-core.S | 4 +-- > arch/arm64/crypto/sha512-ce-core.S | 4 +-- > arch/arm64/crypto/sm3-ce-core.S | 4 +-- > arch/arm64/crypto/sm4-ce-core.S | 4 +-- > 17 files changed, 84 insertions(+), 84 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt