Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191231031938.241705-1-ebiggers@kernel.org>
In-Reply-To: <20191231031938.241705-1-ebiggers@kernel.org>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Tue, 31 Dec 2019 09:14:14 +0100
Message-ID: <CAKv+Gu8F-u4-DNFFZBWpfVwbJ_ARMC3vnPk4Vzz5Q2WYK9nVhg@mail.gmail.com>
Subject: Re: [PATCH 0/8] crypto: remove the CRYPTO_TFM_RES_* flags
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Tue, 31 Dec 2019 at 04:21, Eric Biggers <ebiggers@kernel.org> wrote:
>
> The CRYPTO_TFM_RES_* flags are pointless since they are never checked
> anywhere.  And it's not really possible for anyone to start using them
> without a lot of work, since many drivers aren't setting them or are
> setting them when they shouldn't.
>
> Also, if we ever actually need to start distinguishing ->setkey() errors
> better (which is somewhat unlikely, as it's been a long time with no one
> caring), we'd probably be much better off just using different return
> values, like -EINVAL if the key is invalid for the algorithm vs.
> -EKEYREJECTED if the key was rejected by a policy like "no weak keys".
> That would be much simpler, less error-prone, and easier to test.
>
> So let's just remove these flags for now.  This gets rid of a lot of
> pointless boilerplate code.
>
> Patches 6 and 8 are a bit large since they touch so many drivers, though
> the changes are straightforward and it would seem overkill to do this as
> a series of 70 separate patches.  But let me know if it's needed.
>
> Eric Biggers (8):
>   crypto: chelsio - fix writing tfm flags to wrong place
>   crypto: artpec6 - return correct error code for failed setkey()
>   crypto: atmel-sha - fix error handling when setting hmac key
>   crypto: remove unused tfm result flags
>   crypto: remove CRYPTO_TFM_RES_BAD_BLOCK_LEN
>   crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN
>   crypto: remove CRYPTO_TFM_RES_WEAK_KEY
>   crypto: remove propagation of CRYPTO_TFM_RES_* flags
>
...
>  108 files changed, 218 insertions(+), 917 deletions(-)
>

For the series:
Acked-by: Ard Biesheuvel <ardb@kernel.org>