Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp21799659ybl; Mon, 6 Jan 2020 11:30:12 -0800 (PST) X-Google-Smtp-Source: APXvYqz3V8u7fBezBi+hwHmoRkqu40jH+al1s9jUlBArhWykx6ngQnCQYbCkwx9k4QSkEC/tY5Yh X-Received: by 2002:a05:6830:124b:: with SMTP id s11mr115478873otp.333.1578339011985; Mon, 06 Jan 2020 11:30:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578339011; cv=none; d=google.com; s=arc-20160816; b=vjLVpvhfiEzIz+Yr5Wch1WPBBRVK5SSxiER6E8dNAe4O92MUTeuZgQUL69qqDDafgN tTcspirQ8Q7MU/Bng7JMy4++dd8Lbi8IdTaRB+dBNecmx5MfGQ5MWgj1TgKM1FvVOowJ F2sjlqbgv2aPrM9xEt2x6OtS5dULYC59VW7ucGjVcGwyEU7i0CWX/DrrcCj/FzfPLdzI 0TwSyi2J0UlWYDIixjU12RcnmYyr3t1NTpJ9WktGz9x8OxySBnQEs5ZTT1SDbaUsxtJv UvwdmiVnpxNwAppIo/3Ho9XwcCdbZckyc5Lo5XsBbJcP11iQQ1La64ioPmB6K7THs1Z7 1u4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9Ur3CxFG0cQbKNwUJ75Zx2lXsthVwW+wWDfRyfXmnKM=; b=ZywJBHN8Ghf5e4SQYCgeMYCZa/2KlkvjrbQPNaUmY3DJltEHKPCiE0aVO1gZXz5CpK j81yQMZpAcC7krxhYiJC22f/plo8Sgu5S62Z6f5674VoOD7XHHa8r/uf3P3L8BL3MrSy JK9a7n0e1/oDcQD/6QGKTDl/+kesS+rIB492Dk5cQOBIPpQzxKAwNjE0oNCO9oH9+7yC Ts0Ejs/GYVWMjR0OWnxveXTjWYQREFcai2H5OzaUAjZw95tPeqXKJSXRBNcl+0Ge4wiH 41fPMar0ZYoSYWjIM6whRhKRRHETpzxabxUFXPMCyS0lJ1b+pBV1nAaNb4JQzzipx1oq vVfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MFDHoVhh; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v12si31428649otf.84.2020.01.06.11.29.58; Mon, 06 Jan 2020 11:30:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MFDHoVhh; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726659AbgAFT35 (ORCPT + 99 others); Mon, 6 Jan 2020 14:29:57 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51395 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbgAFT35 (ORCPT ); Mon, 6 Jan 2020 14:29:57 -0500 Received: by mail-wm1-f65.google.com with SMTP id d73so16231229wmd.1; Mon, 06 Jan 2020 11:29:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9Ur3CxFG0cQbKNwUJ75Zx2lXsthVwW+wWDfRyfXmnKM=; b=MFDHoVhhfNfJOoS+7B7TS0SyZvJrXkAmv9gGVyRrLcFaG6lMwTT7g8Nw48eUSo/ihd iE09TrqHNUuJ1yrNx8eqPe/Bf6gJegD+DVCBYVFa3za5W8hLkWvdoLTpZDEEiHtar4+Q pKqqaX4vnkREBw8bLnRfq2kh5v610vdQecjHN/TN8/sSUkLUv+JvKm8Jsa/rdrblmhq0 uhLdN8vIor7xFd3r94ysMJs7hOqQZN08M/sKaaagiqHpkuGpBI7l5slMNOoFkja7LlFr 5lUstKr4VwNTFvhDrVj8RMeFN1GPti+JFk5/Hjf9t0KfwFGuOpMcuYVstzFEf8e8EJkN F22Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9Ur3CxFG0cQbKNwUJ75Zx2lXsthVwW+wWDfRyfXmnKM=; b=Ne6fHnwxMAdkpvT/ZBwkxsuRx5p5OhGVZi/ZW24MHalyPM7hB454YjzR0OdCij3Ss1 exu4VeGdEjuEAlGxYYhhXPRATLvo7SoFNeu2D7/gmsxclCZtH//3bIfUtDhzjHcKwDnK bBUwSG6elt4m7pASCzPL7IjKIbWroBuc1X55soXLevBSJR8iRFpVmbFEDQLFdCfwv4gi LhrN+xL0J2+YDTEBd8Gfjt3VpMgBzZ5bz/RG8hXwKBYNIoBrzmlpYgnR1dviwawUJbcz Og7yOXWdNz2ERYL8Ih+5EJkhlsOmiG0Gou9qsd+BjrpuebtYbmHFP6f5KpCmVX7LPChN JJPg== X-Gm-Message-State: APjAAAWWBtXvJBCQU7fHG+7vcWmV9dubX4KZMZHJ1/LHOZS+OJcen4+Y Xugyfc1FmB4F/HuCVxARi5k= X-Received: by 2002:a1c:1dd7:: with SMTP id d206mr34934742wmd.5.1578338994696; Mon, 06 Jan 2020 11:29:54 -0800 (PST) Received: from Red.localdomain ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g21sm23802398wmh.17.2020.01.06.11.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 11:29:54 -0800 (PST) From: Corentin Labbe To: davem@davemloft.net, herbert@gondor.apana.org.au, narmstrong@baylibre.com Cc: linux-amlogic@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH] crypto: amlogic: fix removal of module Date: Mon, 6 Jan 2020 20:29:50 +0100 Message-Id: <20200106192950.23475-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Removing the driver cause an oops due to the fact we clean an extra channel. Let's give the right index to the cleaning function. Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL") Signed-off-by: Corentin Labbe --- drivers/crypto/amlogic/amlogic-gxl-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c index fa05fce1c0de..9d4ead2f7ebb 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-core.c +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c @@ -289,7 +289,7 @@ static int meson_crypto_probe(struct platform_device *pdev) error_alg: meson_unregister_algs(mc); error_flow: - meson_free_chanlist(mc, MAXFLOW); + meson_free_chanlist(mc, MAXFLOW - 1); clk_disable_unprepare(mc->busclk); return err; } @@ -304,7 +304,7 @@ static int meson_crypto_remove(struct platform_device *pdev) meson_unregister_algs(mc); - meson_free_chanlist(mc, MAXFLOW); + meson_free_chanlist(mc, MAXFLOW - 1); clk_disable_unprepare(mc->busclk); return 0; -- 2.24.1