Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp21800577ybl; Mon, 6 Jan 2020 11:31:12 -0800 (PST) X-Google-Smtp-Source: APXvYqzPdgxXNs3hhRjTFEU+shltbo2JV7JBhVuh45kT2mQBGwglM4YT17K2ILaikZyJXY02XMbO X-Received: by 2002:a05:6808:643:: with SMTP id z3mr6351899oih.19.1578339072274; Mon, 06 Jan 2020 11:31:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578339072; cv=none; d=google.com; s=arc-20160816; b=eqRYyxi7J++IO2/YjQlyimbcavBGYcpcrc54ZOv7opgp+R3OjzyY9DGTf2zzxyK80p Kp4gXLoHmUhIX18hr0t+t+7cfYl1gaqISwqqkiUcK2dfDIc4aHNwWqhtbQqbzo6ee8sv ZtCTxOQi1fUDAHHL98Me67HR2C5qOKsRT1Mcg0uU7WNYPY4W3E9AKWh4adipJU5mUyeO wPrllOtsMFVwkPZEFJCGur6mRVwS7IbZCtTbGqqcTI6aPtiB3309T+XB0Vgt8m+n9glX Z6Lsh0U6QzfutfMxwfSfFmgaUzV9TN8pZE/Cfzq4QC4yY0RgivJAcDVbde7ow5Z5FlJH Z4NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=h+Ho1Pj7J9GuDhhBZpvri/eVbdt/D+i9M0mADHfjbgE=; b=G6FwoKJdfbs8uvcojf4hmfvyzgn966kZA5aML+YVz3CcskR2WtE6X1+PfCzTDgx5ZD 8Kuf+6Ffj2KSXnUH6q4n/Zqih9VxYUr3n5NPA2BIaaa+G8Xbvc9p9K7LveW1udBRfsgS qqRWpE8zCbRWasvUavy9SmsI2uik/dxkkyDciJERPEyPywlmHGGVqPGkwVRkAwYFH4fY cNsc1h0WJxPE4aBcfO4gV1fAyXeESNJN2v3/hndi4jsV1ZdzwJFdFhRkW95sxooHDjeF Nu/Ou7qJvxtJjkZqLWdH3V2PLaLX6ns5BS3GrwPMYJSr2VU6+v4bUyzjT67zwKVdszXw AtqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AZ0GQGKU; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9si30925362oij.125.2020.01.06.11.31.00; Mon, 06 Jan 2020 11:31:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AZ0GQGKU; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726659AbgAFTa7 (ORCPT + 99 others); Mon, 6 Jan 2020 14:30:59 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54528 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbgAFTa7 (ORCPT ); Mon, 6 Jan 2020 14:30:59 -0500 Received: by mail-wm1-f66.google.com with SMTP id b19so16194245wmj.4; Mon, 06 Jan 2020 11:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=h+Ho1Pj7J9GuDhhBZpvri/eVbdt/D+i9M0mADHfjbgE=; b=AZ0GQGKU8r7d3GoITl6teTa4tNztNUC8EnLvD7dYehXxtRaqWMKEFCyc2QOK7b8OV/ JDCLA/e0YuLZj1zwJbtI3sUaZhgwrDH/zn+zI9W3WMGlU98PG5DfiA320CBsdOzpis+C loP8Gzv4OwMAakU1l2GnbV1a8TStBfX7O2nzxLuOQRCkHutC3PRgjLsFUikxnqWoIxIb WgPXZNX+Qrb8F5wM3i7bWwDJ1qnQJMPyACa2C/cop9kNq14Yof4QKwXhImCnKM+NRRo5 Zn7ELNpEDz+G/5k1Y3JWnzx8dWqXClr4QtdxSVxHf5q+ntbANetmJ86H+UfDDLxUDOJm RtPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=h+Ho1Pj7J9GuDhhBZpvri/eVbdt/D+i9M0mADHfjbgE=; b=pzOSUxwuzteBgt2xcgVU9hx+ybMb+Ae8N0FiiZzDN94WF54VRLKxKbr0kwO6WoSUGG 0I+lueX+pK+y8ASBJpvArJ2nawupX3hbpa3zk9gMCY2Tca4hP9sF44PLQvbLGCBfe0Qt Z3rjuBfX/eeLiXAGzCcrnfEYuaQTVzp8bG253mcj8jQLBVWjWYTAM0QOVE+eAmNIKOyQ Z9Ghc3nWKJffiKuigScsFaqq/ir2UNHG1UfK5SnxyThS7K7W+G6VEV8Rh45xjAZMb3lW +o+TQxaMObVZZ5nTRtFiK030aoCf7Pwq2qn4/ubPT1TmS1npYaR4w7iVxhMnFl3o8Ewu YLBA== X-Gm-Message-State: APjAAAW3lnTfwkO7Ui38u4GSnYynYfHgPHsbpeiBr4rACtHW86sl6MUC k0J6yhgK3QsMboza+OQz0QI= X-Received: by 2002:a1c:6a13:: with SMTP id f19mr37837776wmc.20.1578339057153; Mon, 06 Jan 2020 11:30:57 -0800 (PST) Received: from Red.localdomain ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id z83sm24100123wmg.2.2020.01.06.11.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 11:30:56 -0800 (PST) From: Corentin Labbe To: davem@davemloft.net, herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe Subject: [PATCH] crypto: sun8i-ce: fix removal of module Date: Mon, 6 Jan 2020 20:30:53 +0100 Message-Id: <20200106193053.2884-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Removing the driver cause an oops due to the fact we clean an extra channel. Let's give the right index to the cleaning function. Fixes: 06f751b61329 ("crypto: allwinner - Add sun8i-ce Crypto Engine") Signed-off-by: Corentin Labbe --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c index 53739507c8c2..f72346a44e69 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c @@ -624,7 +624,7 @@ static int sun8i_ce_probe(struct platform_device *pdev) error_irq: sun8i_ce_pm_exit(ce); error_pm: - sun8i_ce_free_chanlist(ce, MAXFLOW); + sun8i_ce_free_chanlist(ce, MAXFLOW - 1); return err; } @@ -638,7 +638,7 @@ static int sun8i_ce_remove(struct platform_device *pdev) debugfs_remove_recursive(ce->dbgfs_dir); #endif - sun8i_ce_free_chanlist(ce, MAXFLOW); + sun8i_ce_free_chanlist(ce, MAXFLOW - 1); sun8i_ce_pm_exit(ce); return 0; -- 2.24.1