Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (esa2.microchip.iphmx.com: domain of
  Tudor.Ambarus@microchip.com designates 198.175.253.82 as
  permitted sender) identity=mailfrom;
  client-ip=198.175.253.82; receiver=esa2.microchip.iphmx.com;
  envelope-from="Tudor.Ambarus@microchip.com";
  x-sender="Tudor.Ambarus@microchip.com";
  x-conformance=spf_only; x-record-type="v=spf1";
  x-record-text="v=spf1 mx a:ushub1.microchip.com
  a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com
  include:servers.mcsv.net include:mktomail.com
  include:spf.protection.outlook.com ~all"
Received-SPF: None (esa2.microchip.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@email.microchip.com) identity=helo;
  client-ip=198.175.253.82; receiver=esa2.microchip.iphmx.com;
  envelope-from="Tudor.Ambarus@microchip.com";
  x-sender="postmaster@email.microchip.com";
  x-conformance=spf_only
IronPort-SDR: nutv9ZNUF9QsbJSld5Xi2dVCAMacL/rmV2e6QosdpEFK/zm1KVQRZw3TsQBB0EDXwJYb+O0idC
 CiPIZ0/nTW3VovVqXjZA5COB5asWtqM57CP//wRDZFKlmRsxL2wqeokI+1JzWV4YlCC6Pt7I8t
 F2T4QjHmtnTOqfT4amE1BsuPavedXLa9xqoZCwFS0b4f9e9jT8cpIILdYJiEffSy7guHSgqsOB
 zJ640Txkbp548L5ZgCPMAwg22gjEfhu8e9sbAbDfbXWlNCtrI/asIyCMkifDt4DcDG/xmaT75k
 LrY=
From:   <Tudor.Ambarus@microchip.com>
To:     <linux-crypto@vger.kernel.org>
CC:     <ebiggers@kernel.org>
Subject: Re: [PATCH 3/8] crypto: atmel-sha - fix error handling when setting
 hmac key
Thread-Topic: [PATCH 3/8] crypto: atmel-sha - fix error handling when setting
 hmac key
Thread-Index: AQHVxj2Ii3AtBld1UEew6HdX3jag3A==
Date:   Wed, 8 Jan 2020 16:06:06 +0000
Message-ID: <2028004.Oqa5o8bvTI@localhost.localdomain>
References: <20191231031938.241705-1-ebiggers@kernel.org>
 <20191231031938.241705-4-ebiggers@kernel.org>
In-Reply-To: <20191231031938.241705-4-ebiggers@kernel.org>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0869F0EF533E26408ED7E6D835DAB7E3@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3078aded-d291-4a69-7fa9-08d79454ab38
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2020 16:06:06.5995
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: d6bHJrfy964DV2wkTJaMnQvb78SYArCBLqfvpAG3I3fOzXKQQK6IkThrQvfDgUFqoZu1lOJ8o3oWwukUVgFe6mao/ghqMmaycCjFpJVJDk0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3886
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Tuesday, December 31, 2019 5:19:33 AM EET Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>=20
> HMAC keys can be of any length, and atmel_sha_hmac_key_set() can only
> fail due to -ENOMEM.  But atmel_sha_hmac_setkey() incorrectly treated
> any error as a "bad key length" error.  Fix it to correctly propagate
> the -ENOMEM error code and not set any tfm result flags.
>=20
> Fixes: 81d8750b2b59 ("crypto: atmel-sha - add support to hmac(shaX)")
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  drivers/crypto/atmel-sha.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>=20
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index e8e4200c1ab3..d3bcd14201c2 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -1853,12 +1853,7 @@ static int atmel_sha_hmac_setkey(struct crypto_aha=
sh
> *tfm, const u8 *key, {
>  	struct atmel_sha_hmac_ctx *hmac =3D crypto_ahash_ctx(tfm);
>=20
> -	if (atmel_sha_hmac_key_set(&hmac->hkey, key, keylen)) {
> -		crypto_ahash_set_flags(tfm,=20
CRYPTO_TFM_RES_BAD_KEY_LEN);
> -		return -EINVAL;
> -	}
> -
> -	return 0;
> +	return atmel_sha_hmac_key_set(&hmac->hkey, key, keylen);

The atmel_sha_hmac_key_set() is used just here, maybe it is worth getting r=
id=20
of the function and copy its body here. As this is just a cosmetic suggesti=
on,=20
with or without this, one can add:

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

>  }
>=20
>  static int atmel_sha_hmac_init(struct ahash_request *req)