Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v2 08/10] crypto: caam - add crypto_engine support for
 AEAD algorithms
Thread-Topic: [PATCH v2 08/10] crypto: caam - add crypto_engine support for
 AEAD algorithms
Thread-Index: AQHVwdGvJJHe3rGkXUy7JI3MEOJf4A==
Date:   Fri, 10 Jan 2020 08:31:38 +0000
Message-ID: <VI1PR0402MB3485A163A639D6434E166EEF98380@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1578013373-1956-1-git-send-email-iuliana.prodan@nxp.com>
 <1578013373-1956-9-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fb872179-d1ba-4a94-d6f0-08d795a78327
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2020 08:31:38.7688
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iJ51284OWmaB6PKIbe1PaQZP7Enn+iL5trkJde3U4zo9eIGzFJh5+Zv/FQaypY6CLP+rWw7LolNgIpqYuPkhUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3487
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 1/3/2020 3:04 AM, Iuliana Prodan wrote:=0A=
> +struct caam_aead_req_ctx {=0A=
> +	struct aead_edesc *edesc;=0A=
> +	void (*aead_op_done)(struct device *jrdev, u32 *desc, u32 err,=0A=
> +			     void *context);=0A=
Similar with skcipher, aead_op_done is not needed since aead_crypt_done=0A=
is the only callback used.=0A=
=0A=
> +static int aead_enqueue_req(struct device *jrdev, u32 *desc,=0A=
> +			    void (*cbk)(struct device *jrdev, u32 *desc,=0A=
> +					u32 err, void *context),=0A=
> +			    struct aead_request *req, struct aead_edesc *edesc)=0A=
cbk parameter is not used.=0A=
=0A=
> +{=0A=
> +	struct caam_drv_private_jr *jrpriv =3D dev_get_drvdata(jrdev);=0A=
> +	int ret;=0A=
> +=0A=
> +	if (req->base.flags & CRYPTO_TFM_REQ_MAY_BACKLOG)=0A=
> +		return crypto_transfer_aead_request_to_engine(jrpriv->engine,=0A=
> +								  req);=0A=
Resources leak in case of failure.=0A=
=0A=
> +	else=0A=
> +		ret =3D caam_jr_enqueue(jrdev, desc, aead_crypt_done,=0A=
> +				      &edesc->jrentry);=0A=
Need to justify why only some requests are transferred to crypto engine.=0A=
=0A=
Horia=0A=