Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/9] crypto: hisilicon - fix debugfs usage of SEC V2
To:     Herbert Xu <herbert@gondor.apana.org.au>
References: <1578642598-8584-1-git-send-email-xuzaibo@huawei.com>
 <1578642598-8584-2-git-send-email-xuzaibo@huawei.com>
 <20200110085038.pebelen7a7g2kwwf@gondor.apana.org.au>
CC:     <davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
        <linuxarm@huawei.com>, <jonathan.cameron@huawei.com>,
        <wangzhou1@hisilicon.com>, <tanghui20@huawei.com>,
        <yekai13@huawei.com>, <liulongfang@huawei.com>,
        <qianweili@huawei.com>, <zhangwei375@huawei.com>,
        <fanghao11@huawei.com>, <forest.zhouchang@huawei.com>
From:   Xu Zaibo <xuzaibo@huawei.com>
Message-ID: <041742d8-37b0-2234-9130-3af1e2efef85@huawei.com>
Date:   Fri, 10 Jan 2020 18:49:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20200110085038.pebelen7a7g2kwwf@gondor.apana.org.au>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Hi,


On 2020/1/10 16:50, Herbert Xu wrote:
> On Fri, Jan 10, 2020 at 03:49:50PM +0800, Zaibo Xu wrote:
>> Applied some advices of Marco Elver on atomic usage of Debugfs.
>>
>> Reported-by: Marco Elver <elver@google.com>
>> Signed-off-by: Zaibo Xu <xuzaibo@huawei.com>
>> ---
>>   drivers/crypto/hisilicon/sec2/sec.h        |  6 +++---
>>   drivers/crypto/hisilicon/sec2/sec_crypto.c | 10 +++++-----
>>   drivers/crypto/hisilicon/sec2/sec_main.c   | 14 ++++++++++++--
>>   3 files changed, 20 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/crypto/hisilicon/sec2/sec.h b/drivers/crypto/hisilicon/sec2/sec.h
>> index 26754d0..841f4c5 100644
>> --- a/drivers/crypto/hisilicon/sec2/sec.h
>> +++ b/drivers/crypto/hisilicon/sec2/sec.h
>> @@ -40,7 +40,7 @@ struct sec_req {
>>   	int req_id;
>>   
>>   	/* Status of the SEC request */
>> -	int fake_busy;
>> +	bool fake_busy;
> I have already applied Arnd's patch and it's in the crypto tree.
> Please rebase yours on top of his patch.
>
Okay, I will rebase.

Cheers,
Zaibo

.