Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
To:     Horia Geanta <horia.geanta@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v2 09/10] crypto: caam - add crypto_engine support for RSA
 algorithms
Thread-Topic: [PATCH v2 09/10] crypto: caam - add crypto_engine support for
 RSA algorithms
Thread-Index: AQHVwdGq8oNojU3+Pkqj8F8q9Ip8Bw==
Date:   Mon, 13 Jan 2020 13:06:21 +0000
Message-ID: <VI1PR04MB4445B8ECE7BBF2E64A486FBB8C350@VI1PR04MB4445.eurprd04.prod.outlook.com>
References: <1578013373-1956-1-git-send-email-iuliana.prodan@nxp.com>
 <1578013373-1956-10-git-send-email-iuliana.prodan@nxp.com>
 <VI1PR0402MB3485162217C242B16CF1371B98380@VI1PR0402MB3485.eurprd04.prod.outlook.com>
 <VI1PR04MB44452FF06F35075413CF87F88C350@VI1PR04MB4445.eurprd04.prod.outlook.com>
 <VI1PR0402MB3485EE10F3200D7E7EE1EBA698350@VI1PR0402MB3485.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4accdb92-897b-427b-8f2b-08d7982962eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 13:06:21.5791
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DaHtyHkWUT9jZE5pbj5ukbFiOxdp2TAXBuYuCmaEDgr5XpX3Zxn7nZ4UN65KKIanCaB+14RSmma+nM2wTj+p3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4911
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 1/13/2020 2:21 PM, Horia Geanta wrote:=0A=
> On 1/13/2020 11:48 AM, Iuliana Prodan wrote:=0A=
>> On 1/10/2020 10:46 AM, Horia Geanta wrote:=0A=
>>> On 1/3/2020 3:03 AM, Iuliana Prodan wrote:=0A=
>>>> +static int akcipher_enqueue_req(struct device *jrdev, u32 *desc,=0A=
>>>> +				void (*cbk)(struct device *jrdev, u32 *desc,=0A=
>>>> +					    u32 err, void *context),=0A=
>>>> +				struct akcipher_request *req,=0A=
>>>> +				struct rsa_edesc *edesc)=0A=
>>>> +{=0A=
>>>> +	struct caam_drv_private_jr *jrpriv =3D dev_get_drvdata(jrdev);=0A=
>>>> +	struct crypto_akcipher *tfm =3D crypto_akcipher_reqtfm(req);=0A=
>>>> +	struct caam_rsa_ctx *ctx =3D akcipher_tfm_ctx(tfm);=0A=
>>>> +	struct caam_rsa_key *key =3D &ctx->key;=0A=
>>>> +	int ret;=0A=
>>>> +=0A=
>>>> +	if (req->base.flags & CRYPTO_TFM_REQ_MAY_BACKLOG)=0A=
>>>> +		return crypto_transfer_akcipher_request_to_engine(jrpriv->engine,=
=0A=
>>>> +								  req);=0A=
>>> Resource leak in case transfer fails.=0A=
>>>=0A=
>>>> +	else=0A=
>>>> +		ret =3D caam_jr_enqueue(jrdev, desc, cbk, &edesc->jrentry);=0A=
>>> What's the problem with transferring all requests to crypto engine?=0A=
>>>=0A=
>> I'll address all your comments in v3.=0A=
>>=0A=
>> Regarding the transfer request to crypto-engine: if sending all requests=
=0A=
>> to crypto-engine, multibuffer tests, for non-backlogging requests fail=
=0A=
>> after only 10 requests, since crypto-engine queue has 10 entries.=0A=
>> Here's an example:=0A=
>> root@imx6qpdlsolox:~# insmod tcrypt.ko mode=3D422 num_mb=3D1024=0A=
>> insmod: ERROR: could not insert module tcrypt.ko: Resource temporarily=
=0A=
>> unavailable=0A=
>> root@imx6qpdlsolox:~#=0A=
>> root@imx6qpdlsolox:~# dmesg=0A=
>> ...=0A=
>> testing speed of multibuffer sha1 (sha1-caam)=0A=
>> tcrypt: test  0 (   16 byte blocks,   16 bytes per update,   1 updates):=
=0A=
>> tcrypt: concurrent request 11 error -28=0A=
>> tcrypt: concurrent request 13 error -28=0A=
>> tcrypt: concurrent request 14 error -28=0A=
>> tcrypt: concurrent request 16 error -28=0A=
>> tcrypt: concurrent request 18 error -28=0A=
>> tcrypt: concurrent request 20 error -28=0A=
>> tcrypt: concurrent request 22 error -28=0A=
>> tcrypt: concurrent request 24 error -28=0A=
>> tcrypt: concurrent request 26 error -28=0A=
>> tcrypt: concurrent request 28 error -28=0A=
>> tcrypt: concurrent request 30 error -28=0A=
>> tcrypt: concurrent request 32 error -28=0A=
>> tcrypt: concurrent request 34 error -28=0A=
>>=0A=
>> tcrypt: concurrent request 1020 error -28=0A=
>> tcrypt: concurrent request 1022 error -28=0A=
>> tcrypt: At least one hashing failed ret=3D-28=0A=
>> root@imx6qpdlsolox:~#=0A=
>>=0A=
>> If sending just the backlog request to crypto-engine, and non-blocking=
=0A=
>> directly to CAAM, these tests have a better chance to pass since JR has=
=0A=
>> 1024 entries.=0A=
>>=0A=
>> Will need to work/update crypto-engine: set queue length when initialize=
=0A=
>> crypto-engine, and remove serialization of requests in crypto-engine.=0A=
>> But, until then, I would like to have a backlogging solution in CAAM dri=
ver.=0A=
>>=0A=
> My point is you need to add details about the current limitations=0A=
> in the commit message (even in the source code, it wouldn't hurt),=0A=
> justifying the choice of not using crypto engine for all requests.=0A=
> =0A=
Yes, I understand your point and, as I mentioned above, I'll address all =
=0A=
comments, from all patches, in v3:=0A=
- update commit messages;=0A=
- handle resource leak in case of crypto-engine transfer;=0A=
- remove unnecessary variables, in some structs;=0A=
- will remove patch #6.=0A=
=0A=
Iulia=0A=