Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3992371ybl; Mon, 13 Jan 2020 06:11:23 -0800 (PST) X-Google-Smtp-Source: APXvYqy+fI5vILUuWLNAH4kvD51dzgALF0xDcFXz5eHaU9kdQFICZUmHxRQG24zlg3VjBRug3NQz X-Received: by 2002:aca:6744:: with SMTP id b4mr13287311oiy.99.1578924683138; Mon, 13 Jan 2020 06:11:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1578924683; cv=pass; d=google.com; s=arc-20160816; b=nLqXBHHK1JNfMzja4c1h6Nfn4yT40Rwd3wL66dEUGGZ4AMMX1pLSdLRZRD25eg0YeH 942mjmYROX8hQC1tTsFWEpqbdUw6Tx8Bsyc2Rq/QVJ0VTuzj6vB9PJ4jfd00XY9Y5oSE Ux0S5Cy9Tgp8hA95VVKtQmkwcq75I7XAvs5pVkpY37lrYJoH3tTTOJnltlZ3M6WqFWUz z5R7K8Zapa1UDsNtIIgz5aHgqipG51T5YZq6x40ddsMExOEP5Z1mubs35L9aBamn7esS Th7KCFyKtrwapu9Eio0PDpLRXc9AK4LmEA6b/rALUpWYNzOwFDoWzGR23126TGfDM9Ok hUxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=D9DMPCovZ+xXPYNT7l96Ad1GW7sy5NoWEhcnlbNAhBE=; b=lRcyR7S8+u5Iq5pK/6dPsiHTNOdHw+3unkZI9Zye+VI5nC1US1CglfOmjP1RvvQqMn eH5R9bnOu6Kz5U8QtmoChM8PCWYy9t4mIaI7KdJ/7OscXoLnciPe4RJFakf0mVho3R2W sou6nNQAgbL9e1SGIKuk574cT1p2ujTzkMm81V0RaJFBC2AMCBHiTudfq7piiYAddS4m Cr9MQshRmpILTZ5gEWp9W8PqyE2WKWRApNk/P/gkZkE/PdH/p7X2HocbE7sWMXH/oo5N fsCEi8Sbjzow+QD/hbRAQHHgd6IEeI5iSz0BjKMQhWCSWrBxnVAFME0FKycRB5UW1Kfu liCA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=BVjuQ4zs; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k19si4023384otb.118.2020.01.13.06.11.04; Mon, 13 Jan 2020 06:11:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=BVjuQ4zs; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728753AbgAMOKy (ORCPT + 99 others); Mon, 13 Jan 2020 09:10:54 -0500 Received: from mail-db8eur05on2060.outbound.protection.outlook.com ([40.107.20.60]:6642 "EHLO EUR05-DB8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728734AbgAMOKy (ORCPT ); Mon, 13 Jan 2020 09:10:54 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=brJi9jpCTOsF4GOoTyE/sFgG+qn6QAFDxrGiIeVbVo8Dc7zc5sZxQYFhR7R1Vgw5HCHSFvqqF8SFy6dVhnqqoR5My1H+2OAFe6/fQ63PO9G6nY91M+q6On0arBIQtlNV66txY3SnJXuQuvIVfriLcYRN63NNJ05XgPGsEg5cCqvVXTYFx0h1qVAsQMYsc+vgQM3LCNIL1CE2x5EFmv+F5hEbGzcV3tEOeH/2KxfErcx50mtuz26mxDv5v9nDCuRjYH8r0JYmHz+RxaZBGpCpBfiZ4tE8BlQXCPEqiaBhjoeoSp0AHZw4KlbpeTH62E4GHo1zMWA+EM/TM0/MOFKYDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9DMPCovZ+xXPYNT7l96Ad1GW7sy5NoWEhcnlbNAhBE=; b=gIlman79Fy/D267HKTe5ruX7/pjn6MNrnaGJV07hbm70ZEYaxb6xgCWiMEDdRyhaPJls7VWSghfQ9WB/c7FhZqR0TwsW+R4TUQUHsRXGjzYbYj4Ql45wIWSw+ZFyy34AyXogUyP/A9VHDCAOTR/7UZ3hwbM04rOWZJjuIeNnc4fhgqnH636Rw2Tjtf2GvHqC5eToZ52rafWC7OzZpUJeXN/6OKNh/++X3Xi4HCRlY6RD+oEQrtHF2/UN77bZHfp8mRxdaX18pxeqYP8oNAZoUSHRBwJvdnAw+srcGjzruKOfjlCtWUSpYvECi/Gj8WLCZuvcvM6fgzRxRnCNPFg6iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9DMPCovZ+xXPYNT7l96Ad1GW7sy5NoWEhcnlbNAhBE=; b=BVjuQ4zsEmQyvh1/OPZ50/8iR1WraJjOh7uuOI0Ijdhc0s3jlY07WHAEOulgZrDJDgPkJdLnn62J/8mnucD9pWQL6YTV8fRsGa84HcgnqA452O++kiC6JfCNOUuVKDWR6ukkVEePKz+2i32Ka4HJH+P8UbYAwuKAxZEHARGscN4= Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com (52.134.3.153) by VI1PR0402MB3918.eurprd04.prod.outlook.com (52.134.16.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.13; Mon, 13 Jan 2020 14:10:51 +0000 Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::85e9:f844:f8b0:27d]) by VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::85e9:f844:f8b0:27d%7]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 14:10:51 +0000 From: Horia Geanta To: Andrey Smirnov , "linux-crypto@vger.kernel.org" CC: Chris Healy , Lucas Stach , Herbert Xu , Iuliana Prodan , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH v6 7/7] crypto: caam - limit single JD RNG output to maximum of 16 bytes Thread-Topic: [PATCH v6 7/7] crypto: caam - limit single JD RNG output to maximum of 16 bytes Thread-Index: AQHVxjovOVxhRz2BlkaaDb9wDSI3Mw== Date: Mon, 13 Jan 2020 14:10:51 +0000 Message-ID: References: <20200108154047.12526-1-andrew.smirnov@gmail.com> <20200108154047.12526-8-andrew.smirnov@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [212.146.100.6] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 939ab4a3-7d0e-4645-537f-08d798326555 x-ms-traffictypediagnostic: VI1PR0402MB3918:|VI1PR0402MB3918: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(199004)(189003)(54906003)(44832011)(110136005)(71200400001)(186003)(2906002)(53546011)(8676002)(81156014)(8936002)(33656002)(6506007)(81166006)(966005)(76116006)(66946007)(52536014)(66476007)(316002)(64756008)(55016002)(91956017)(86362001)(45080400002)(478600001)(4326008)(7696005)(26005)(66556008)(5660300002)(9686003)(66446008)(4744005);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB3918;H:VI1PR0402MB3485.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t4v/B52QhFFj8FojVD2QwwFwYtgPrZcOqEYTUFNA7Rlt+txDSGUHOrOZbFY+bmJDoOWLDg0WG9ePfXLu81r4gvFyIU45T02hHtZ7RCWRMkETlg8cxHS8CULi37Sa4aLnBp7AXS6JDdNOMzZmORrW3Df8vPJvCFu5ehVT5vSJbEr7f0flWFfmnEwiHqxNWXK/0KUrnS3BuKmFxR5F6KRSQIbueV+qxnM1BcAsaHmdu+w7RkTR1RrxeVvTzdEoa20p5vBwUybq/9f3/AkcNubsLcASXVe5LhCqbVpZSgp0997ZGZQD87Y3OdpUX8wgWBayMc2RbHPRMPQX0/O4S9Q/2bA17F0KvvHyauxP7wysqBKKxv2iKtGoiANHz9x+fQ+MxkDQI/YJEGlbytj5oEzhPSLlcgr4G04ivjrF7dLum4WRX9TBC9rSHRsBbs3liEwY Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 939ab4a3-7d0e-4645-537f-08d798326555 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 14:10:51.0402 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DFTuM6SiU06MvKw1zU32GLZdXFtOxBMQRYO5c5kmxB2tWH0vQ96KKpeOxBv1nHjIji2LUrMPbC+XNx2pZlA/JQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3918 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 1/8/2020 5:42 PM, Andrey Smirnov wrote:=0A= > In order to follow recommendation in SP800-90C (section "9.4 The=0A= > Oversampling-NRBG Construction") limit the output of "generate" JD=0A= > submitted to CAAM. See=0A= > https://lore.kernel.org/linux-crypto/VI1PR0402MB3485EF10976A4A69F90E5B0F9= 8580@VI1PR0402MB3485.eurprd04.prod.outlook.com/=0A= > for more details.=0A= > =0A= > This change should make CAAM's hwrng driver good enough to have 999=0A= > quality rating.=0A= > =0A= [...]=0A= > @@ -241,6 +241,7 @@ int caam_rng_init(struct device *ctrldev)=0A= > ctx->rng.init =3D caam_init;=0A= > ctx->rng.cleanup =3D caam_cleanup;=0A= > ctx->rng.read =3D caam_read;=0A= > + ctx->rng.quality =3D 999;=0A= > =0A= AFAICS the maximum value of hwrng.quality is 1024.=0A= =0A= Any reason why it's configured to be lower, now that CAAM RNG-based DRBG=0A= is configured to reseed as requested by FIPS spec to behave as a TRNG?=0A= =0A= Horia=0A=