Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        "baolin.wang@linaro.org" <baolin.wang@linaro.org>
CC:     Horia Geanta <horia.geanta@nxp.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Silvano Di Ninno <silvano.dininno@nxp.com>
Subject: Re: [PATCH v2 09/10] crypto: caam - add crypto_engine support for RSA
 algorithms
Thread-Topic: [PATCH v2 09/10] crypto: caam - add crypto_engine support for
 RSA algorithms
Thread-Index: AQHVwdGq8oNojU3+Pkqj8F8q9Ip8Bw==
Date:   Tue, 14 Jan 2020 10:40:53 +0000
Message-ID: <VI1PR04MB4445E44C69277F17CFBDB9128C340@VI1PR04MB4445.eurprd04.prod.outlook.com>
References: <1578013373-1956-1-git-send-email-iuliana.prodan@nxp.com>
 <1578013373-1956-10-git-send-email-iuliana.prodan@nxp.com>
 <VI1PR0402MB3485162217C242B16CF1371B98380@VI1PR0402MB3485.eurprd04.prod.outlook.com>
 <VI1PR04MB44452FF06F35075413CF87F88C350@VI1PR04MB4445.eurprd04.prod.outlook.com>
 <20200114001440.baeadihvlqiucw63@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a6b0f04f-10c5-4f20-e33b-08d798de3b42
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2020 10:40:53.9666
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7XqXcpGgUnQLpqSIPZ3vp5teIRza4qf0llkdYzb9jkLi1YPmpMP8f/1VQlCwhE5LUsOt8a1BnAQLoFKpdtLPDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6960
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 1/14/2020 2:14 AM, Herbert Xu wrote:=0A=
> On Mon, Jan 13, 2020 at 09:48:11AM +0000, Iuliana Prodan wrote:=0A=
>>=0A=
>> Regarding the transfer request to crypto-engine: if sending all requests=
=0A=
>> to crypto-engine, multibuffer tests, for non-backlogging requests fail=
=0A=
>> after only 10 requests, since crypto-engine queue has 10 entries.=0A=
> =0A=
> That isn't right.  The crypto engine should never refuse to accept=0A=
> a request =0A=
Crypto-engine accepts all request that have the backlog flag, the =0A=
non-backlog are accepted till the configured limit (of 10).=0A=
=0A=
> unless the hardware queue is really full.  =0A=
Crypto-engine doesn't check the status of hardware queue.=0A=
The non-backlog requests are dropped after 10 entries.=0A=
=0A=
> Perhaps the=0A=
> crypto engine code needs to be fixed?=0A=
To me, crypto-engine seems to be made for backlogged request, that's why =
=0A=
I'm sending the non-backlog directly to CAAM. The implicit serialization =
=0A=
of request in crypto-engine is the bottleneck.=0A=
=0A=
But, as I said before, I want to update crypto-engine to set queue =0A=
length when initialize crypto-engine, and remove serialization of =0A=
requests in crypto-engine by adding knowledge about the underlying hw =0A=
accelerator (number of request that can be processed in parallel).=0A=
I'll send a RFC with my proposal for crypto-engine enhancements.=0A=
=0A=
But, until then, I would like to have a backlogging solution in CAAM driver=
.=0A=
=0A=
Thanks,=0A=
Iulia=0A=