Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7594135ybl; Thu, 16 Jan 2020 02:16:50 -0800 (PST) X-Google-Smtp-Source: APXvYqyIpYwucQSV1eJTwZQtQRgEXUpxN89KXavX0thhOvzhvHQKsiApaYMPxNGiO0tqp91bVNCB X-Received: by 2002:a9d:6b12:: with SMTP id g18mr1320439otp.211.1579169810056; Thu, 16 Jan 2020 02:16:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579169810; cv=none; d=google.com; s=arc-20160816; b=MI6+2suU01JkGnJaiNOtxoaYDlblwKn02029QUemBIZiwKST9EmpzSWM2Wfnr+UcVf KRr/TAcky3+CMSdllLvqLcX8hcKYR/QjpWsK+OUxDP+DJ/ystPTXiCqm4AaAmYa5+VC0 GSoNVIEZcpe1RwsPF5iCeYzgbbiWhjmCWD/RT7yXD5sDK1X9mdOaleDiO7GmteQptvFk vWqLRorKBmTFPtPPHZu1cW07MA0dNX1F8AqfYtwpCNPwBEnjK+JxCwtDb8SR9h25zDWT R25ni0fv7M2S50PNgK/YxJ3mHWKyF7xBCvdjCA3Ip5H+htim5LuaCofmP0CBiwVHF81t eU4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=YqgMDwpDwkv/GNDraFVJEvKY/MlRlQMZz986fOkDIZw=; b=F5QlQolOTHLR+xVZ0/lNqJ/rD6ISZE76Zw+WXgF5cWBL9LNWXbfphlRjeVGS7d10VP Ak16nSxnPZgsvbLbX6Xs1NOu3OO+5fIjSvyKpTbp39XqgR1OVhmQYIzNNVqc1YoppO55 MWrvdFcq+1dRZpy+X1y3uhVcIg5AIdWY49KLPg4+f2bjCLOBVgyRh3u4mVDi06ySI9Xi fGOvmIXwHo4CQLdEyRxbHOdnLv685BFaLy9ID5n7iirdrUheMLi459q4R/2CrJfREoUJ KJsoA9dKQUHs6LonHtP0cLp3F4MQoX8E5Z0mvmwUsK9Yzmj/4jfz4fPJqBVPvC6KLXU3 /QEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k19si10204193otb.118.2020.01.16.02.16.38; Thu, 16 Jan 2020 02:16:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731792AbgAPKPa (ORCPT + 99 others); Thu, 16 Jan 2020 05:15:30 -0500 Received: from foss.arm.com ([217.140.110.172]:47526 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731897AbgAPKP3 (ORCPT ); Thu, 16 Jan 2020 05:15:29 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8A42E13D5; Thu, 16 Jan 2020 02:15:29 -0800 (PST) Received: from e110176-lin.arm.com (unknown [10.50.4.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 30BEC3F534; Thu, 16 Jan 2020 02:15:28 -0800 (PST) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" Cc: Ofir Drang , Hadar Gat , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/11] crypto: ccree - make cc_pm_put_suspend() void Date: Thu, 16 Jan 2020 12:14:45 +0200 Message-Id: <20200116101447.20374-11-gilad@benyossef.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20200116101447.20374-1-gilad@benyossef.com> References: <20200116101447.20374-1-gilad@benyossef.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org cc_pm_put_suspend() return value was never checked and is not useful. Turn it into a void functions. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/ccree/cc_pm.c | 7 ++----- drivers/crypto/ccree/cc_pm.h | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/ccree/cc_pm.c b/drivers/crypto/ccree/cc_pm.c index ee9e9cba2fbb..24c368b866f6 100644 --- a/drivers/crypto/ccree/cc_pm.c +++ b/drivers/crypto/ccree/cc_pm.c @@ -73,17 +73,14 @@ int cc_pm_get(struct device *dev) return (rc == 1 ? 0 : rc); } -int cc_pm_put_suspend(struct device *dev) +void cc_pm_put_suspend(struct device *dev) { - int rc = 0; struct cc_drvdata *drvdata = dev_get_drvdata(dev); if (drvdata->pm_on) { pm_runtime_mark_last_busy(dev); - rc = pm_runtime_put_autosuspend(dev); + pm_runtime_put_autosuspend(dev); } - - return rc; } bool cc_pm_is_dev_suspended(struct device *dev) diff --git a/drivers/crypto/ccree/cc_pm.h b/drivers/crypto/ccree/cc_pm.h index a7d98a5da2e1..04289beb6e3e 100644 --- a/drivers/crypto/ccree/cc_pm.h +++ b/drivers/crypto/ccree/cc_pm.h @@ -21,7 +21,7 @@ void cc_pm_fini(struct cc_drvdata *drvdata); int cc_pm_suspend(struct device *dev); int cc_pm_resume(struct device *dev); int cc_pm_get(struct device *dev); -int cc_pm_put_suspend(struct device *dev); +void cc_pm_put_suspend(struct device *dev); bool cc_pm_is_dev_suspended(struct device *dev); #else @@ -50,10 +50,7 @@ static inline int cc_pm_get(struct device *dev) return 0; } -static inline int cc_pm_put_suspend(struct device *dev) -{ - return 0; -} +static inline void cc_pm_put_suspend(struct device *dev) {} static inline bool cc_pm_is_dev_suspended(struct device *dev) { -- 2.23.0