Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
To:     Corentin Labbe <clabbe.montjoie@gmail.com>,
        "alexandre.torgue@st.com" <alexandre.torgue@st.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
        "mripard@kernel.org" <mripard@kernel.org>,
        "wens@csie.org" <wens@csie.org>,
        Horia Geanta <horia.geanta@nxp.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH RFC 09/10] crypto: engine: permit to batch requests
Thread-Topic: [PATCH RFC 09/10] crypto: engine: permit to batch requests
Thread-Index: AQHVyuLsCMmCcJsnqU6cDfOK2wZNrg==
Date:   Thu, 16 Jan 2020 11:34:34 +0000
Message-ID: <VI1PR04MB4445182A8A827C3EA303A2978C360@VI1PR04MB4445.eurprd04.prod.outlook.com>
References: <20200114135936.32422-1-clabbe.montjoie@gmail.com>
 <20200114135936.32422-10-clabbe.montjoie@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: cc7d1cc7-1848-47ef-f84e-08d79a780fc5
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2020 11:34:34.6480
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qDAKvTY8ZwVEF+2SRLCJRXSSdQd/L6gw0cPkXsr9rc471vpmjvA28c7qp+pMuhqr18orkZkdXIb9JkPsKffMvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7184
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 1/14/2020 4:00 PM, Corentin Labbe wrote:=0A=
> Now everything is ready, this patch permits to choose the number of=0A=
> request to batch.=0A=
> =0A=
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>=0A=
> ---=0A=
>   crypto/crypto_engine.c  | 32 +++++++++++++++++++++++++++-----=0A=
>   include/crypto/engine.h |  2 ++=0A=
>   2 files changed, 29 insertions(+), 5 deletions(-)=0A=
> =0A=
> diff --git a/crypto/crypto_engine.c b/crypto/crypto_engine.c=0A=
> index e23a398ba330..e9cd9ec9a732 100644=0A=
> --- a/crypto/crypto_engine.c=0A=
> +++ b/crypto/crypto_engine.c=0A=
> @@ -114,6 +114,7 @@ static void crypto_pump_requests(struct crypto_engine=
 *engine,=0A=
>   	}=0A=
>   =0A=
>   	engine->ct =3D 0;=0A=
> +retry:=0A=
>   	/* Get the fist request from the engine queue to handle */=0A=
>   	backlog =3D crypto_get_backlog(&engine->queue);=0A=
>   	async_req =3D crypto_dequeue_request(&engine->queue);=0A=
> @@ -151,7 +152,10 @@ static void crypto_pump_requests(struct crypto_engin=
e *engine,=0A=
>   		}=0A=
>   		engine->cur_reqs[engine->ct].prepared =3D true;=0A=
>   	}=0A=
> -	engine->ct++;=0A=
> +	if (++engine->ct < engine->rmax && engine->queue.qlen > 0) {=0A=
> +		spin_lock_irqsave(&engine->queue_lock, flags);=0A=
> +		goto retry;=0A=
> +	}=0A=
>   	if (!enginectx->op.do_one_request) {=0A=
>   		dev_err(engine->dev, "failed to do request\n");=0A=
>   		ret =3D -EINVAL;=0A=
> @@ -393,15 +397,18 @@ int crypto_engine_stop(struct crypto_engine *engine=
)=0A=
>   EXPORT_SYMBOL_GPL(crypto_engine_stop);=0A=
>   =0A=
>   /**=0A=
> - * crypto_engine_alloc_init - allocate crypto hardware engine structure =
and=0A=
> + * crypto_engine_alloc_init2 - allocate crypto hardware engine structure=
 and=0A=
>    * initialize it.=0A=
>    * @dev: the device attached with one hardware engine=0A=
>    * @rt: whether this queue is set to run as a realtime task=0A=
> + * @rmax: The number of request that the engine can batch in one=0A=
> + * @qlen: The size of the crypto queue=0A=
>    *=0A=
>    * This must be called from context that can sleep.=0A=
>    * Return: the crypto engine structure on success, else NULL.=0A=
>    */=0A=
> -struct crypto_engine *crypto_engine_alloc_init(struct device *dev, bool =
rt)=0A=
> +struct crypto_engine *crypto_engine_alloc_init2(struct device *dev, bool=
 rt,=0A=
> +						int rmax, int qlen)=0A=
=0A=
I think one _alloc_init function is enough, which will set the size of =0A=
crypto-engine queue (not hardcoded like it is now) and the number of =0A=
requests that the engine can execute in parallel.=0A=
=0A=
{=0A=
>   	struct sched_param param =3D { .sched_priority =3D MAX_RT_PRIO / 2 };=
=0A=
>   	struct crypto_engine *engine;=0A=
> @@ -421,12 +428,12 @@ struct crypto_engine *crypto_engine_alloc_init(stru=
ct device *dev, bool rt)=0A=
>   	engine->priv_data =3D dev;=0A=
>   	snprintf(engine->name, sizeof(engine->name),=0A=
>   		 "%s-engine", dev_name(dev));=0A=
> -	engine->rmax =3D 1;=0A=
> +	engine->rmax =3D rmax;=0A=
>   	engine->cur_reqs =3D devm_kzalloc(dev, sizeof(struct cur_req) * engine=
->rmax, GFP_KERNEL);=0A=
>   	if (!engine->cur_reqs)=0A=
>   		return NULL;=0A=
>   =0A=
> -	crypto_init_queue(&engine->queue, CRYPTO_ENGINE_MAX_QLEN);=0A=
> +	crypto_init_queue(&engine->queue, qlen);=0A=
>   	spin_lock_init(&engine->queue_lock);=0A=
>   =0A=
>   	engine->kworker =3D kthread_create_worker(0, "%s", engine->name);=0A=
> @@ -443,6 +450,21 @@ struct crypto_engine *crypto_engine_alloc_init(struc=
t device *dev, bool rt)=0A=
>   =0A=
>   	return engine;=0A=
>   }=0A=
> +EXPORT_SYMBOL_GPL(crypto_engine_alloc_init2);=0A=
> +=0A=
> +/**=0A=
> + * crypto_engine_alloc_init - allocate crypto hardware engine structure =
and=0A=
> + * initialize it.=0A=
> + * @dev: the device attached with one hardware engine=0A=
> + * @rt: whether this queue is set to run as a realtime task=0A=
> + *=0A=
> + * This must be called from context that can sleep.=0A=
> + * Return: the crypto engine structure on success, else NULL.=0A=
> + */=0A=
> +struct crypto_engine *crypto_engine_alloc_init(struct device *dev, bool =
rt)=0A=
> +{=0A=
> +	return crypto_engine_alloc_init2(dev, rt, 1, CRYPTO_ENGINE_MAX_QLEN);=
=0A=
> +}=0A=
>   EXPORT_SYMBOL_GPL(crypto_engine_alloc_init);=0A=
>   =0A=
>   /**=0A=
> diff --git a/include/crypto/engine.h b/include/crypto/engine.h=0A=
> index 55d3dbc2498c..fe0dfea8bf07 100644=0A=
> --- a/include/crypto/engine.h=0A=
> +++ b/include/crypto/engine.h=0A=
> @@ -115,6 +115,8 @@ void crypto_finalize_skcipher_request(struct crypto_e=
ngine *engine,=0A=
>   int crypto_engine_start(struct crypto_engine *engine);=0A=
>   int crypto_engine_stop(struct crypto_engine *engine);=0A=
>   struct crypto_engine *crypto_engine_alloc_init(struct device *dev, bool=
 rt);=0A=
> +struct crypto_engine *crypto_engine_alloc_init2(struct device *dev, bool=
 rt,=0A=
> +						int rmax, int qlen);=0A=
>   int crypto_engine_exit(struct crypto_engine *engine);=0A=
>   =0A=
>   #endif /* _CRYPTO_ENGINE_H */=0A=
> =0A=
=0A=