Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3474575ybl; Mon, 27 Jan 2020 04:51:09 -0800 (PST) X-Google-Smtp-Source: APXvYqwzYuQcysgwD8YiMgMaCuNSvFFNNB6braAa7KrCP38zMIVVkO/6jFry9+w0gheXKHVbzKas X-Received: by 2002:aca:534f:: with SMTP id h76mr7442545oib.23.1580129469015; Mon, 27 Jan 2020 04:51:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580129469; cv=none; d=google.com; s=arc-20160816; b=mPSz/r56drlDpy/iK8NRW6D12NtsdCju5FUZ+OTO7dVsmJKie7C+wolhwM7yXL0+Hm S+5SmXdFeK0BUE3jxEFXDuNkAdMp2kE4ifbOpKeepApQ9/fMaNZwC5JfeWscvQV0oAj6 E+xU2EwtdUel6laCMOjHhMu7LTrh0m880F4shoG+m5mAKQWVKnGh4M04i4vuF78PsjaL QSj2S/0DhKEtpiLZElAlNMok4CwR1aUG8vi9sB7cDeYzEqY96FtvmRGULi99kZr+7vYS uN1kbkOWxtQaNv4CCgJC6HC5wiFvFb0OispdphiihIPnKB7Plwr6PF4xCVe0eTRGyjHu bizw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=DPqjuIBcwHn8dZPbuBt1sI2Nk6MVaZC6TW/sVPgwVec=; b=Se7xjaN3LgqwvlBzBPf5a2uuqIpQuAgVS5JGsqxE4hDr876cbP4WroO3U7SbCYJ4ER L4MESdfDCfw+op6d7tG63UImskgK3h5C67E7SfPVZ4fdjpBBb1fpvm43DOsV9RYrkcEU VLfmS2uoJFndevoX6vaWpOdQYtpoODROYK7GBqfZXt9anlFhyaC2/TJEmXeFoWz92mjB 969yIYuIR8UEvGf4HCaDIf9cxFmGNyPCaonffDSgHXEZvWlpKqRVdBdeg76JZbUpDd1H as5CMcVYWkLfqPy5rP5/I2mdWWw58z4kFmprE9aPtds7J29mS4EqFU7OwAHl6zKdacbq g39g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si7483163otq.250.2020.01.27.04.50.58; Mon, 27 Jan 2020 04:51:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729708AbgA0MdP (ORCPT + 99 others); Mon, 27 Jan 2020 07:33:15 -0500 Received: from foss.arm.com ([217.140.110.172]:43906 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727326AbgA0MdP (ORCPT ); Mon, 27 Jan 2020 07:33:15 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0850830E; Mon, 27 Jan 2020 04:33:15 -0800 (PST) Received: from e110176-lin.kfn.arm.com (e110176-lin.kfn.arm.com [10.50.4.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A2C023F52E; Mon, 27 Jan 2020 04:33:13 -0800 (PST) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" , Eric Biggers Cc: Ofir Drang , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: testmgr - properly mark the end of scatterlist Date: Mon, 27 Jan 2020 14:33:11 +0200 Message-Id: <20200127123311.7137-1-gilad@benyossef.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The inauthentic AEAD test were using a scatterlist which could have a mismarked end node. Fixes: 49763fc6b1 ("crypto: testmgr - generate inauthentic AEAD test vectors") Signed-off-by: Gilad Ben-Yossef --- crypto/testmgr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 88f33c0efb23..6c432aecff97 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -2225,6 +2225,8 @@ static void generate_aead_message(struct aead_request *req, generate_random_bytes((u8 *)vec->ptext, vec->plen); sg_set_buf(&src[i++], vec->ptext, vec->plen); } + if (i) + sg_mark_end(&src[(i-1)]); sg_init_one(&dst, vec->ctext, vec->alen + vec->clen); memcpy(iv, vec->iv, ivsize); aead_request_set_callback(req, 0, crypto_req_done, &wait); -- 2.23.0