Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3610942ybl; Mon, 27 Jan 2020 07:10:18 -0800 (PST) X-Google-Smtp-Source: APXvYqx7uDV6UZnvpOTvIYgPe+LznyAjdR7z6TRGCIqPrJzvLCuEAkgV3EkSQdbZIz0gRo0yuJ+y X-Received: by 2002:aca:ad47:: with SMTP id w68mr7381283oie.63.1580137818302; Mon, 27 Jan 2020 07:10:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580137818; cv=none; d=google.com; s=arc-20160816; b=o61or+85HdyI29j02w5A2t632Xz9SoNZ2cGSFBL2YL2JqXq78J7Uaso8aQisgkBKOx LJsd/Hsqt+frminh25rrwnzXAEZADSgiKZoS2F5QTCRhc3VAmfaMjmYMVdrulkRBqTqO RXYM/ftarK0kGihWkGY9s/h/3jTNsvOqBJYUVdgVVSTy3gno5TeNND/FUcP/8dqOBIh7 Fyrt4jBUvYc7HZHdHPKQjhuDvJhkqu3a4aqGB0NUyFox4ybpt59JzFPZk4M7fQXYNdRG Ltr4EBb+A4R8SGI8kHyn8AbOsgbkgt2PKP2yNN6gsGtG02adoxzuNzfpWPNm2i2BpLhw EPBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=NkoAUVzWFZjHMMtEdPmvHpOHaSeOlTobo/dhUR4U2mI=; b=NpKHRxZeCCKg3ch9qbMhrI6H7v71k+DhYGFrJH9hwgdCdUqPoUls7U26M7vFf2CoXI k/0a3w6GgCVQcMiy+kUrKIg+lnPAB/vF2EPGYYHP1znNJVdpdbq+9vvcBhNn3UduvTQj vphSngQ+Rwo3w+LPYMmoS3GM0oOVPTGkpzm2NDwUM7+hoD0eaabjrwCK9IralxUjGvdU 5K6tz0uVCBTm4QbsI1lM6zRJnYmFid6mraF5DmVpU2E3/Vyc/h4rXRtf+upNtFH4TkMe HubqsVBV8Rz++RPMfeozeTUBcT5EcmxJAhgGbqBSFBY/5mc2mYk5Dfg1Bk1NBwSpR6Mc bntQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@benyossef-com.20150623.gappssmtp.com header.s=20150623 header.b=gB8aH9bX; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d14si7292383otp.151.2020.01.27.07.10.05; Mon, 27 Jan 2020 07:10:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@benyossef-com.20150623.gappssmtp.com header.s=20150623 header.b=gB8aH9bX; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729147AbgA0PKE (ORCPT + 99 others); Mon, 27 Jan 2020 10:10:04 -0500 Received: from mail-vs1-f66.google.com ([209.85.217.66]:40646 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbgA0PKE (ORCPT ); Mon, 27 Jan 2020 10:10:04 -0500 Received: by mail-vs1-f66.google.com with SMTP id g23so5817865vsr.7 for ; Mon, 27 Jan 2020 07:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NkoAUVzWFZjHMMtEdPmvHpOHaSeOlTobo/dhUR4U2mI=; b=gB8aH9bXLODaT5xi6+YHilW7T0QWwBAAdJXLkkbJnINh/xj60xu3s2hA6DzCwXv+DS 3aQFGUF9eIk05QAu4EhBap3BxPNU4qG6au51QwFeTW6qPx1AckH1AbWL8k1K0WsC5wu5 vHie2JLP6hSf9W+59v383Hpr35ojnQNblt8gf+ozgUyd/GQzPax1JGQbCOCSA1sbpmxe x2bjcvOhEjsaSKEZ25/CkFgazKBSIvHnyz1d+6VQBFH8EKS4Kj7vHhlyZAZJPYd2084W UeUtrhvCVukGhxtzatJIyWhVYMlrdc0lzhy8m5b9p8BUVYRi/aH2dGrsABVOrOYg3PeH dilA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NkoAUVzWFZjHMMtEdPmvHpOHaSeOlTobo/dhUR4U2mI=; b=F3RVd3uN06a0hecdnPLgXicp+ope9Ad5UyxZNLltcnvvkBi6ynCF4Blo8cDjfsU0G0 91nclcmX6DvTdlsGh1sXLlL/aae32cQly5ZcPv3PlmFCFmIJ4fmec/wAxh4NTIv5khvW 3hG2Mgsv+1i9TzDGzHfdRYRaOB+PSL+dWRC2bKomAoX4vs3fPA0jN5+uKiSIoJuTLZHo Iuwe1AHOlDeJsPllQrqKUqA7kNKrb7ET0OyeamXpkaKD5uO+iiY5NqM6v9DIHei7AtPu XRctV7itRMEOjRahaV8o9iSQPHazsljb01la1PqGuSnq/2uoNFLG5ujkrRDjvIOtqTfp vIHQ== X-Gm-Message-State: APjAAAUUsJxt1FTpg4ep2IbsISvYiRnXa9JUyoY6syhimYlXjOVUI/6O aSlPDNVhoQ02wCpY7UjTG5jfstqDSMVpHqd21CoJ1y4CSdM= X-Received: by 2002:a67:fb14:: with SMTP id d20mr9765471vsr.136.1580137803056; Mon, 27 Jan 2020 07:10:03 -0800 (PST) MIME-Version: 1.0 References: <20200127122939.6952-1-gilad@benyossef.com> In-Reply-To: From: Gilad Ben-Yossef Date: Mon, 27 Jan 2020 17:09:51 +0200 Message-ID: Subject: Re: [RFC] crypto: ccree - protect against short scatterlists To: Geert Uytterhoeven Cc: Herbert Xu , "David S. Miller" , Ofir Drang , Linux Crypto Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jan 27, 2020 at 2:52 PM Geert Uytterhoeven w= rote: > > Hi Gilad, > > On Mon, Jan 27, 2020 at 1:29 PM Gilad Ben-Yossef wr= ote: > > Deal gracefully with the event of being handed a scatterlist > > which is shorter than expected. > > > > This mitigates a crash in some cases of Crypto API calls due with > > scatterlists with a NULL first buffer, despite the aead.h > > forbidding doing so. > > > > Signed-off-by: Gilad Ben-Yossef > > Reported-by: Geert Uytterhoeven > > Thanks for your patch! > > Unable to handle kernel paging request at virtual address fffeffffc000000= 0 OK, this is a progress of a sort. We now crash during unmap, not map. Sent another go. If this doesn't work I'll wait till I reunite with the boa= rd. Blind debugging is hard... Thanks again! Gilad values of =CE=B2 will give rise to dom!