Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1580650021-8578-1-git-send-email-hadar.gat@arm.com>
In-Reply-To: <1580650021-8578-1-git-send-email-hadar.gat@arm.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 3 Feb 2020 10:54:48 +0100
Message-ID: <CAK8P3a3C7hfCQwupKQqtnOmwu7faoeKH9fcEZFQW3WmrScKzUw@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] hw_random: introduce Arm CryptoCell TRNG driver
To:     Hadar Gat <hadar.gat@arm.com>
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Stefan Wahren <wahrenst@gmx.net>,
        Sumit Garg <sumit.garg@linaro.org>,
        Zaibo Xu <xuzaibo@huawei.com>,
        Weili Qian <qianweili@huawei.com>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>, DTML <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Gilad Ben-Yossef <gilad@benyossef.com>,
        Ofir Drang <ofir.drang@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Sun, Feb 2, 2020 at 2:27 PM Hadar Gat <hadar.gat@arm.com> wrote:
>
> The Arm CryptoCell is a hardware security engine.
> This patch introduces driver for its TRNG (True Random Number Generator)
> engine.
>
> Changes from previous veriosn: fixed 'make dt_bnding_check' errors.
>
> Hadar Gat (3):
>   dt-bindings: add device tree binding for Arm CryptoCell trng engine
>   hw_random: cctrng: introduce Arm CryptoCell driver
>   MAINTAINERS: add HG as cctrng maintainer

I looked at the patches briefly and everything makes sense to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

There are two style issues that you could improve:

- The header is only included from a single file, so I would just fold
  its contents into the driver itself.

- You have a lot of "#ifdef CONFIG_PM" that are easy to get wrong
  with various combinations of config symbols. It's often better to
  leave that all compiled unconditionally and have the logic in
  UNIVERSAL_DEV_PM_OPS() take care of dropping the unused
  bits, with a __maybe_unused annotation on functions that cause
  a warning otherwise.

       Arnd