Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5009564ybl; Tue, 4 Feb 2020 06:08:52 -0800 (PST) X-Google-Smtp-Source: APXvYqwm8SVvA71e98HlTN6kSEJhCK8z9Y0zDWSfOz7AcKWcL2uZyHKjPZJ9GUIaMmXs/ZdB2Iet X-Received: by 2002:a05:6830:11c8:: with SMTP id v8mr11719371otq.330.1580825332627; Tue, 04 Feb 2020 06:08:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1580825332; cv=pass; d=google.com; s=arc-20160816; b=YC+5ft/52MVw9YBV/BZnumspyDpKgYITb/RmR1Wm/q9AyWkVfEBJKfaUVRCwTNVRV/ vbmvc3ZQYXLbkx1RzKtZn6BfavDmN5C14R1Tsd0Jo9il2CvGFf69MQ4N6uF219bZqlpU veuOUnFSVoUtrnCCaikFL3WDgXfx+InI4gU5rzf0kkmqjDkYobcz1kbI62XADVFSx6mF eUqDd+FMLA82S8QAo9eQ642XxSkVEKyLrIpndvrWq3n+mqRfTeAEnowrpUuCk3Ki/fhX AHyPH+fZSeU8D46WekD51NjqzkK6ijPgJx/qm5zrr20LyD34SKwO56YDzqxjmjkJShCo 123g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=f2RvehsuBBP44KB6zOhDPrdWQ0L4M24POqLlm9qZlto=; b=Qftw8MR8WBredTLYoJ83MPvUc/0XIBXGelMVEsMIkVybufXm4t7CeiNSwODqe+Fvas CmRP6WTk8UFHBbpYEw+hNyqeo/GPcJ+0yQIcYY5bYMeTUFQCxP0wvNYtVZvvKUhqjoKr dxjBwzlgfqi1tjWNUzicmtcy1mg58ikJ9/URazQVi4r0txMLBws5civAkS+15jcli2PA /NNvGHCEs68JIBf3RIOuHRgIbfP05SrUYQTo8LCmVVR3FRL3ZcBkLcTbmwCEMTVIfla4 cqTdWfX1GcAnBP17qB3yEdjSncUCmo/FLioAEvNWwpfpgI180OPD6+8W2KBRd2VEd+1w etpg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=kVH5JxNL; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si13373485otg.66.2020.02.04.06.08.32; Tue, 04 Feb 2020 06:08:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=kVH5JxNL; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727218AbgBDOI0 (ORCPT + 99 others); Tue, 4 Feb 2020 09:08:26 -0500 Received: from mail-eopbgr80042.outbound.protection.outlook.com ([40.107.8.42]:29667 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727210AbgBDOI0 (ORCPT ); Tue, 4 Feb 2020 09:08:26 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BZIQ1j81TPp80gTQIylo5gbitsA77GwhE/7ZvIXGmz/KyFxq8RTJ32/KV3P1hhUhmTyvkGkrb7X/pXpI7RaUIXPPKN5Yl7IxYHiCFUqs8mHlJWbr2WtX0s0aGcNjddX6iPgKdyE7SPLExvy1N3ZKnQ+KOU2nVPFHyFAd0UY8JkIiiUDLlJMSmspk8SF8QIY9zS52C02nhcebXqzUCkMetiwq3qUcS8IL8NoQtOQNok8eddhpLvQ6gfNq+e61NuITGUOwYBmtTy6xMroNLiQakkhu7JHNiAzEe8EwFhSbAlUVx9ABCqdxn8YvMQTfGJX6AlrjyBDNyTkOhk6HSJdYZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f2RvehsuBBP44KB6zOhDPrdWQ0L4M24POqLlm9qZlto=; b=OQPU+gVpPuyugix7BI6vhsZM3o1PfbwcEvZh7XYwEW/jbxhiuuYWWUtBfGTkbN1UQXt57mXVAo6oksMoFUzWsZAy1XxujapvQQ88x2IsmeaM74sQzPGvjFcwYyutv+SWF5ojA7cC7SU0PePZqK/gmdXPNG0NvQ8qKtlWCBqn84sx4Piqd6q9xCVpvKjVQ8InTkqKWo4kRTnmInXuiM3ckb/JswcnvZNqXoDX2Avxj6WUqlKaN51TGrpzEAe92VlXhhspeRRxXyl7Q5U0rBYb6n2dSFUii6b5vnXnd2EWb1o2ooNztxf9bj3KipVlsNlsFNOjM3FZlVxxlJ4baqXXoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f2RvehsuBBP44KB6zOhDPrdWQ0L4M24POqLlm9qZlto=; b=kVH5JxNLABC6/R88v2ZSWwZYPSlvFVIOLJq9HHGKVvbFtXYF2N7xFSpQ2BEvC2NxcXriRncCfPbrTFrjRh3o/+CCGjvAnkMBLiHxioPyaT3CFGKqaJRtXceLgQS+YRIK2vPWCSTlJsiC89kNxcoSazLeHBDG2UxlShTBSWTTubU= Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com (52.134.3.153) by VI1PR0402MB2814.eurprd04.prod.outlook.com (10.172.255.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.27; Tue, 4 Feb 2020 14:08:22 +0000 Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::85e9:f844:f8b0:27d]) by VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::85e9:f844:f8b0:27d%7]) with mapi id 15.20.2686.028; Tue, 4 Feb 2020 14:08:22 +0000 From: Horia Geanta To: Andrey Smirnov , "linux-crypto@vger.kernel.org" CC: Chris Healy , Lucas Stach , Herbert Xu , Iuliana Prodan , dl-linux-imx , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v7 1/9] crypto: caam - allocate RNG instantiation descriptor with GFP_DMA Thread-Topic: [PATCH v7 1/9] crypto: caam - allocate RNG instantiation descriptor with GFP_DMA Thread-Index: AQHV1TLP0i8oyBdn6EKevKHj+QF50A== Date: Tue, 4 Feb 2020 14:08:22 +0000 Message-ID: References: <20200127165646.19806-1-andrew.smirnov@gmail.com> <20200127165646.19806-2-andrew.smirnov@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [212.146.100.6] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 99aedb3b-81c5-437a-d9dd-08d7a97bb1e4 x-ms-traffictypediagnostic: VI1PR0402MB2814:|VI1PR0402MB2814: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 03030B9493 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(189003)(199004)(91956017)(66556008)(66446008)(76116006)(66946007)(66476007)(64756008)(110136005)(5660300002)(4744005)(54906003)(26005)(71200400001)(316002)(6506007)(53546011)(33656002)(44832011)(86362001)(7696005)(55016002)(186003)(4326008)(478600001)(9686003)(52536014)(8936002)(2906002)(8676002)(81156014)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB2814;H:VI1PR0402MB3485.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LZpyo1amEVGjUBGJqR2OkzyTwkxjjR8S+ifsqfdxSOISK1csspvvWurykZDMYA9OB27JoRudUy2gpcmHEMv0ebmC7RslPJlz28XNDSFokrtvYLDJ4h1rYb6pqepKot009gNOjNST1NP847SICh8+dhjD/fnX9UJAeg/lIAq8M0CYwQIsuNppkA5z9IjiWqfVQ9bCyqnwlbYkdkd9BQbqRFzacI7ioHHcH85/4mJ8iyNtAkYQsnhbNM2h4mgVsZ1EgIS+MroNTF0yzlH0coxKlqo0NVS+L+2ukCUnlDZb6apeG2XYKAC2e6uPCBhSDxdPmTKZh3oEGoWOw2xy7Sr6+c4uBU4IG6GUPS821jQ2eLcx05+jM+s1eQwFFYLymNKcGFPph66mu8h6CcQtPOG/MW9QJB990e1Axy1TwHZZ5CweGN13RJ8ynpPvqH16gOe/ x-ms-exchange-antispam-messagedata: eKo64oB86Qq3qrx6jEz3qn+WAHnRTT33IwYElR8gMXIGzz6BqgX0f6TSxkNkYWCqAG/2oj53Lnekz5zF3KPuaOzBY901/eF+kpjvBdAL2kI7P63gIKr7U55GPtZOKGRigTPxpC6uzay4tdpmtkwpjQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99aedb3b-81c5-437a-d9dd-08d7a97bb1e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2020 14:08:22.5292 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h0j/Ms00l3Kx/lRT5wejPT3TNfjZ/Q3EF6LD9d0zrMlV2ESnJ1S6IdX65BWZ14oxz4FkpHPw9OflYTCqbGHaGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2814 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 1/27/2020 6:57 PM, Andrey Smirnov wrote:=0A= > Be consistent with the rest of the codebase and use GFP_DMA when=0A= > allocating memory for a CAAM JR descriptor.=0A= > =0A= Please use GFP_DMA32 instead.=0A= Device is not limited to less than 32 bits of addressing=0A= in any of its incarnations.=0A= =0A= s/GFP_DMA/GFP_DMA32 should be performed throughout caam driver.=0A= (But of course, I wouldn't include this change in current patch series).=0A= =0A= Horia=0A=