Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp273438ybv; Tue, 4 Feb 2020 21:20:24 -0800 (PST) X-Google-Smtp-Source: APXvYqx3pS3bFuCPvc70FS4ZYpHrgmmSNhlDxHosjdu/GrJcOahUHBm9XXMKeQidcqb5Gyn2I0Zi X-Received: by 2002:a05:6830:2102:: with SMTP id i2mr24379004otc.123.1580880024695; Tue, 04 Feb 2020 21:20:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580880024; cv=none; d=google.com; s=arc-20160816; b=H9a251NIKKmqLCbDMBjl1qQ9povayq57eGx9lUVMvnqCKctvgf89m5dC3utIwnp6tB I14tUjiOCOV+mYwJzgt6mRBM58gFqMfV+0YqJ/uqqZPMuiAa5SHyCa4+EyO15wPhelQw lWHW44Szs5UmR+jE6CvKuURWQRzAblkyZXC1r9kHfQ8rWYmKquzmmVoWYrHly+TT2yWm PZG89jnrdFE2ovmov7+zJJM3EP6Xk3dhe/G1f1XcLx7bTyKODMopmItZ1Wktlk+cwcr5 gRUwixSPenupmW3WFcQNvw/J0gAD/XCJiylcyYdV2881O9sF3oc0RwS1vDjy0AIMBeBu IBrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GlOvnl44Vaz+kaoBsTOUVLVOsQrfZ5Ft29r1CVNy5NM=; b=xOfZOh3cpACdm8fA8ZlZtonIKk37ZVWy8NyJSXg+ieSf9mp35defZua5rVvxPpTrqi hKvr8/4BmLFhvzaVE31MnIatvDgLRL36T82hDc46e5Nut+F7xxFSM8LkOAch2Tyv8xEg BxCQz1iNriWT5al1WzxXxySLACj7s8dU4nn2ZgzK3cbSYgW9CIMeHE0VZSz3rETvQvnd moxR2wFwg6C7AOgAKQlcchd8yBg8Th9C8QEvYgwF2kuf2gKAcvFBbFVpfFaz/qwpNO5E lt2l6TN06mArzZ3Rd6lRdMKLM6bNpYDiwhIW0aeUkvxTO3EPzefEj/I7h9AFmONAnXdY zVMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3si12720952otc.272.2020.02.04.21.20.14; Tue, 04 Feb 2020 21:20:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725913AbgBEFTk (ORCPT + 99 others); Wed, 5 Feb 2020 00:19:40 -0500 Received: from stargate.chelsio.com ([12.32.117.8]:19113 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbgBEFTk (ORCPT ); Wed, 5 Feb 2020 00:19:40 -0500 Received: from chumthang.blr.asicdesigners.com (chumthang.blr.asicdesigners.com [10.193.186.96]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 0155J7iT019895; Tue, 4 Feb 2020 21:19:34 -0800 From: Ayush Sawal To: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org Cc: manojmalviya@chelsio.com, Ayush Sawal Subject: [PATCH crypto/chcr 2/2] This fixes the kernel panic which occurs during a libkcapi test Date: Wed, 5 Feb 2020 10:48:42 +0530 Message-Id: <20200205051842.29324-3-ayush.sawal@chelsio.com> X-Mailer: git-send-email 2.25.0.114.g5b0ca87 In-Reply-To: <20200205051842.29324-1-ayush.sawal@chelsio.com> References: <20200205051842.29324-1-ayush.sawal@chelsio.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The libkcapi test which causes kernel panic is aead asynchronous vmsplice multiple test. ./bin/kcapi -v -d 4 -x 10 -c "ccm(aes)" -q 4edb58e8d5eb6bc711c43a6f3693daebde2e5524f1b55297abb29f003236e43d -t a7877c99 -n 674742abd0f5ba -k 2861fd0253705d7875c95ba8a53171b4 -a fb7bc304a3909e66e2e0c5ef952712dd884ce3e7324171369f2c5db1adc48c7d This patch avoids dma_mapping of a zero length sg which causes the panic, by using sg_nents_for_len which maps only upto a specific length Signed-off-by: Ayush Sawal --- drivers/crypto/chelsio/chcr_algo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c index 699e3053895a..02b0ddb785a4 100644 --- a/drivers/crypto/chelsio/chcr_algo.c +++ b/drivers/crypto/chelsio/chcr_algo.c @@ -2489,8 +2489,9 @@ int chcr_aead_dma_map(struct device *dev, else reqctx->b0_dma = 0; if (req->src == req->dst) { - error = dma_map_sg(dev, req->src, sg_nents(req->src), - DMA_BIDIRECTIONAL); + error = dma_map_sg(dev, req->src, + sg_nents_for_len(req->src, dst_size), + DMA_BIDIRECTIONAL); if (!error) goto err; } else { -- 2.25.0.114.g5b0ca87