Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Robin Gong <yibin.gong@nxp.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC:     =?iso-8859-1?Q?Andr=E9_Draszik?= <git@andred.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Anson Huang <anson.huang@nxp.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 2/3] Input: snvs_pwrkey - enable snvs clock as needed
Thread-Topic: [PATCH 2/3] Input: snvs_pwrkey - enable snvs clock as needed
Thread-Index: AQHV35muNBIBR/iti0mqpaUfcGw1rg==
Date:   Mon, 10 Feb 2020 06:33:30 +0000
Message-ID: <VI1PR0402MB34851857F012286250BF3BBE98190@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <20200130204516.4760-1-git@andred.net>
 <20200130204516.4760-2-git@andred.net>
 <VI1PR0402MB3485EC2F82DDE52DC5CA0795981C0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
 <20200209223836.GA199269@dtor-ws>
 <VE1PR04MB6638A4F4E3BABE0ED0CD4A5189190@VE1PR04MB6638.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c486d2cc-3528-4bb1-3bc9-08d7adf3254c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2020 06:33:30.9376
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JTZPSjPV101M+GXmm05d+Dv+K+CGsv/Il7fWui4U4C2yI4J2CG9LhG43ZHadxixoKu2M7w/obgBagvBqlPZ8NQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3344
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 2/10/2020 4:03 AM, Robin Gong wrote:=0A=
> On 2020/02/10 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: =0A=
>> On Fri, Feb 07, 2020 at 08:10:22AM +0000, Horia Geanta wrote:=0A=
>>> On 1/30/2020 10:45 PM, Andr=E9 Draszik wrote:=0A=
>>>> @@ -140,6 +148,25 @@ static int imx_snvs_pwrkey_probe(struct=0A=
>> platform_device *pdev)=0A=
>>>>  	if (pdata->irq < 0)=0A=
>>>>  		return -EINVAL;=0A=
>>>>=0A=
>>>> +	pdata->clk =3D devm_clk_get(&pdev->dev, "snvs-pwrkey");=0A=
>>>> +	if (IS_ERR(pdata->clk)) {=0A=
>>>> +		pdata->clk =3D NULL;=0A=
>>> Using devm_clk_get_optional() would simplify error handling.=0A=
>>=0A=
>> It sounds to me that this clock is not at all optional and the driver cu=
rrently=0A=
>> "works" only by accident and therefore optional is not suitable here.=0A=
> Yes, then we need to add all snvs clk in dts for on legacy i.MX chips in =
this patchset=0A=
> to avoid any potential function broken.=0A=
In that case the DT binding should be updated too,=0A=
to make the clock mandatory.=0A=
But before doing this all i.MX SoCs should be checked.=0A=
=0A=
Thanks,=0A=
Horia=0A=